From: "naamax.meir" <naamax.meir@linux.intel.com>
To: Kurt Kanzenbach <kurt@linutronix.de>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
intel-wired-lan@lists.osuosl.org,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2 1/2] igc: Report VLAN EtherType matching back to user
Date: Mon, 25 Dec 2023 11:47:02 +0200 [thread overview]
Message-ID: <c3f3e361-e875-41fb-929c-ea3f0773c8d3@linux.intel.com> (raw)
In-Reply-To: <20231201075043.7822-2-kurt@linutronix.de>
On 12/1/2023 09:50, Kurt Kanzenbach wrote:
> Currently the driver allows to configure matching by VLAN EtherType.
> However, the retrieval function does not report it back to the user. Add
> it.
>
> Before:
> |root@host:~# ethtool -N enp3s0 flow-type ether vlan-etype 0x8100 action 0
> |Added rule with ID 63
> |root@host:~# ethtool --show-ntuple enp3s0
> |4 RX rings available
> |Total 1 rules
> |
> |Filter: 63
> | Flow Type: Raw Ethernet
> | Src MAC addr: 00:00:00:00:00:00 mask: FF:FF:FF:FF:FF:FF
> | Dest MAC addr: 00:00:00:00:00:00 mask: FF:FF:FF:FF:FF:FF
> | Ethertype: 0x0 mask: 0xFFFF
> | Action: Direct to queue 0
>
> After:
> |root@host:~# ethtool -N enp3s0 flow-type ether vlan-etype 0x8100 action 0
> |Added rule with ID 63
> |root@host:~# ethtool --show-ntuple enp3s0
> |4 RX rings available
> |Total 1 rules
> |
> |Filter: 63
> | Flow Type: Raw Ethernet
> | Src MAC addr: 00:00:00:00:00:00 mask: FF:FF:FF:FF:FF:FF
> | Dest MAC addr: 00:00:00:00:00:00 mask: FF:FF:FF:FF:FF:FF
> | Ethertype: 0x0 mask: 0xFFFF
> | VLAN EtherType: 0x8100 mask: 0x0
> | VLAN: 0x0 mask: 0xffff
> | User-defined: 0x0 mask: 0xffffffffffffffff
> | Action: Direct to queue 0
>
> Fixes: 2b477d057e33 ("igc: Integrate flex filter into ethtool ops")
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
> Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
next prev parent reply other threads:[~2023-12-25 9:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 7:50 [PATCH iwl-net v2 0/2] igc: ethtool: Check VLAN TCI mask Kurt Kanzenbach
2023-12-01 7:50 ` [PATCH iwl-net v2 1/2] igc: Report VLAN EtherType matching back to user Kurt Kanzenbach
2023-12-01 9:55 ` [EXT] " Suman Ghosh
2023-12-01 13:31 ` Kurt Kanzenbach
2023-12-01 16:16 ` Suman Ghosh
2023-12-06 7:45 ` Kurt Kanzenbach
2023-12-10 11:51 ` Simon Horman
2023-12-25 9:47 ` naamax.meir [this message]
2023-12-01 7:50 ` [PATCH iwl-net v2 2/2] igc: Check VLAN TCI mask Kurt Kanzenbach
2023-12-10 11:51 ` Simon Horman
2023-12-26 10:49 ` [Intel-wired-lan] " naamax.meir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3f3e361-e875-41fb-929c-ea3f0773c8d3@linux.intel.com \
--to=naamax.meir@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).