From: Eduard Zingerman <eddyz87@gmail.com>
To: Slava Imameev <slava.imameev@crowdstrike.com>,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org
Cc: martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
haoluo@google.com, jolsa@kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, shuah@kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-open-source@crowdstrike.com
Subject: Re: [PATCH bpf-next v4 1/2] bpf: Support new pointer param types via SCALAR_VALUE for trampolines
Date: Tue, 03 Mar 2026 12:05:04 -0800 [thread overview]
Message-ID: <c40dd219ea60f810d52576f998e68cc0d731f761.camel@gmail.com> (raw)
In-Reply-To: <20260303095427.38981-2-slava.imameev@crowdstrike.com>
On Tue, 2026-03-03 at 20:54 +1100, Slava Imameev wrote:
[...]
> @@ -6902,11 +6921,7 @@ bool btf_ctx_access(int off, int size, enum bpf_access_type type,
> }
> }
>
> - /*
> - * If it's a pointer to void, it's the same as scalar from the verifier
> - * safety POV. Either way, no futher pointer walking is allowed.
> - */
> - if (is_void_or_int_ptr(btf, t))
> + if (is_ptr_treated_as_scalar(btf, t))
> return true;
I'm probably missing a point here, but what's wrong with Alexei's
suggestion to do this instead:
if (is_ptr_treated_as_scalar(btf, t))
return true;
?
Only two new tests fail:
- #554/62 verifier_ctx_ptr_param/fentry/pointer to float - invalid ctx access:FAIL
- #554/63 verifier_ctx_ptr_param/fentry/double pointer to float - invalid ctx access:FAIL
But I'd say this shouldn't matter.
This will also make selftests much simpler.
>
> /* this is a pointer to another type */
next prev parent reply other threads:[~2026-03-03 20:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 9:54 [PATCH bpf-next v4 0/2] bpf: Add multi-level pointer parameter support for trampolines Slava Imameev
2026-03-03 9:54 ` [PATCH bpf-next v4 1/2] bpf: Support new pointer param types via SCALAR_VALUE " Slava Imameev
2026-03-03 20:05 ` Eduard Zingerman [this message]
2026-03-03 21:49 ` Slava Imameev
2026-03-03 22:43 ` Eduard Zingerman
2026-03-04 0:22 ` Slava Imameev
2026-03-04 0:36 ` Alexei Starovoitov
2026-03-04 0:38 ` Eduard Zingerman
2026-03-10 12:16 ` Slava Imameev
2026-03-10 18:52 ` Eduard Zingerman
2026-03-11 13:07 ` Slava Imameev
2026-03-11 16:31 ` Eduard Zingerman
2026-03-03 9:54 ` [PATCH bpf-next v4 2/2] selftests/bpf: Add trampolines single and multi-level pointer params test coverage Slava Imameev
2026-03-03 20:08 ` Eduard Zingerman
2026-03-03 22:14 ` Slava Imameev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c40dd219ea60f810d52576f998e68cc0d731f761.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-open-source@crowdstrike.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=slava.imameev@crowdstrike.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox