From: Til Kaiser <mail@tk154.de>
To: sashiko-reviews@lists.linux.dev
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/3] net: ethernet: qualcomm: ppe: Add IPQ5332 support
Date: Sat, 17 Oct 2026 20:37:27 +0200 [thread overview]
Message-ID: <c40f4d8f-223c-441b-901e-5bea5bcb612e@tk154.de> (raw)
In-Reply-To: <sashiko-outbox-175580@kernel.org>
On 10/17/26 5:25 PM, sashiko-bot@kernel.org wrote:
>
> [Severity: High]
> Does ppe_config_qm() calculate the multicast queue register address correctly
> when queue_id is >= 256?
>
> In ppe_config_qm(), the code calculates the address like this:
>
> } else {
> reg = PPE_AC_MULTICAST_QUEUE_CFG_TBL_ADDR +
> PPE_AC_MULTICAST_QUEUE_CFG_TBL_INC * queue_id;
>
> Since queue_id ranges from 256 to 299 for multicast queues, and is not offset
> by 256 (PPE_AC_UNICAST_QUEUE_CFG_TBL_ENTRIES) before multiplication, does this
> result in an out-of-bounds address calculation?
>
This is the pre-existing issue you identified in v1, affecting IPQ9574 as well.
I submitted the fix separately to net:
https://lore.kernel.org/all/20261016150140.929729-2-mail@tk154.de/
I could also mention this in the commit message or add the link to the net series
in the cover letter.
prev parent reply other threads:[~2026-10-17 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 15:24 [PATCH net-next v2 0/3] net: ethernet: qualcomm: ppe: Add IPQ5332 support Til Kaiser
2026-10-16 15:24 ` [PATCH net-next v2 1/3] net: ethernet: qualcomm: ppe: Select hardware configuration by SoC Til Kaiser
2026-10-16 15:24 ` [PATCH net-next v2 2/3] dt-bindings: net: qcom,ipq9574-ppe: Add IPQ5332 support Til Kaiser
2026-10-16 15:24 ` [PATCH net-next v2 3/3] net: ethernet: qualcomm: ppe: " Til Kaiser
[not found] ` <sashiko-outbox-175580@kernel.org>
2026-10-17 18:37 ` Til Kaiser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c40f4d8f-223c-441b-901e-5bea5bcb612e@tk154.de \
--to=mail@tk154.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox