From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E241C4321E for ; Thu, 1 Dec 2022 11:44:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230452AbiLALoj (ORCPT ); Thu, 1 Dec 2022 06:44:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230223AbiLALoh (ORCPT ); Thu, 1 Dec 2022 06:44:37 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E27539D836; Thu, 1 Dec 2022 03:44:35 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8E625B81F17; Thu, 1 Dec 2022 11:44:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D7ACC433D6; Thu, 1 Dec 2022 11:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669895073; bh=PrMg5m3+X14CGC2gNHxtuuuFETrafX7CmaULS1L0xC8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KkYZx1vsZ5aPJ+Ehvk6Dk4EprgL/RyuUL3nmeCaI6ZqrnVThqA8uq01p5q+gO0FnD 44YQdq4xrdBD8fGzfh6od2MhxdCY7Z7zBzEbDxxGbZ6Qyhe+hgfCbkwDZP2p1kOTy0 VyIwHxKQhrTsRoLIuWEj+Ob3oHf3JhiiAOzohXfmM0zxUN2glcR4HnuCW+90pmphGB 2oeJfKNl9SgmtO9KGfi6lqjtTzyagr60o2HE744oEEhtxuHTwsOKmjGiBZg+A1Uig3 SrCyLw9xCjJ90mADn7rx3pQP5xl3hP+Wb+Z9kC6ybyjOZHqj5US045e8x+sez29alo CFH2FHRMJ9VBA== Message-ID: Date: Thu, 1 Dec 2022 13:44:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4 net-next 4/6] net: ethernet: ti: am65-cpsw: Add suspend/resume support Content-Language: en-US To: Paolo Abeni , davem@davemloft.net, maciej.fijalkowski@intel.com, kuba@kernel.org Cc: andrew@lunn.ch, edumazet@google.com, vigneshr@ti.com, linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221129133501.30659-1-rogerq@kernel.org> <20221129133501.30659-5-rogerq@kernel.org> <9fdc4e0eee7ead18c119b6bc3e93f7f73d2980cd.camel@redhat.com> From: Roger Quadros In-Reply-To: <9fdc4e0eee7ead18c119b6bc3e93f7f73d2980cd.camel@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On 01/12/2022 13:40, Paolo Abeni wrote: > On Tue, 2022-11-29 at 15:34 +0200, Roger Quadros wrote: >> @@ -555,11 +556,26 @@ static int am65_cpsw_nuss_ndo_slave_open(struct net_device *ndev) >> struct am65_cpsw_common *common = am65_ndev_to_common(ndev); >> struct am65_cpsw_port *port = am65_ndev_to_port(ndev); >> int ret, i; >> + u32 reg; >> >> ret = pm_runtime_resume_and_get(common->dev); >> if (ret < 0) >> return ret; >> >> + /* Idle MAC port */ >> + cpsw_sl_ctl_set(port->slave.mac_sl, CPSW_SL_CTL_CMD_IDLE); >> + cpsw_sl_wait_for_idle(port->slave.mac_sl, 100); >> + cpsw_sl_ctl_reset(port->slave.mac_sl); >> + >> + /* soft reset MAC */ >> + cpsw_sl_reg_write(port->slave.mac_sl, CPSW_SL_SOFT_RESET, 1); >> + mdelay(1); >> + reg = cpsw_sl_reg_read(port->slave.mac_sl, CPSW_SL_SOFT_RESET); >> + if (reg) { >> + dev_err(common->dev, "soft RESET didn't complete\n"); > > I *think* Andrew was asking for dev_dbg() here, but let's see what he > has to say :) In the earlier revision we were not exiting with error, so dev_dbg() was more appropriate there. In this revision we error out so I thought dev_err() was ok. -- cheers, -roger