From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="kQ0AYm+C" Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [IPv6:2001:41d0:203:375::b5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F23B7BC for ; Wed, 29 Nov 2023 21:30:52 -0800 (PST) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1701322248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eob5IaL3C73YjDz/8348IYqWx3CyH6zPvNLXIBnL3ig=; b=kQ0AYm+CxcpUX2FJWXQO1LiND3zF+LyUX7MSrFp6H+GCdTu11tBw8He8rQnfjCg9E4SxUJ TkzwahXpviaakgvqqmP9KHoEIJFJ8f46pqJHW4L8Ixde+6Anuo8EWN1RhmjjRO0yGj33jQ 7DgbPVRHiqz4N9hRoS4mDBZ6gnLKXtQ= Date: Thu, 30 Nov 2023 13:30:40 +0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance To: Xuan Zhuo Cc: Liang Chen , jasowang@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, pabeni@redhat.com, alexander.duyck@gmail.com, "Michael S. Tsirkin" References: <20230526054621.18371-1-liangchen.linux@gmail.com> <20230526054621.18371-2-liangchen.linux@gmail.com> <20231129095825-mutt-send-email-mst@kernel.org> <0c2efe49-03db-4616-a4e5-26ff0434e323@linux.dev> <1701311694.1163726-1-xuanzhuo@linux.alibaba.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: <1701311694.1163726-1-xuanzhuo@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 在 2023/11/30 10:34, Xuan Zhuo 写道: > On Wed, 29 Nov 2023 23:29:10 +0800, Zhu Yanjun wrote: >> 在 2023/11/29 23:22, Zhu Yanjun 写道: >>> 在 2023/11/29 22:59, Michael S. Tsirkin 写道: >>>> On Wed, Nov 29, 2023 at 10:50:57PM +0800, Zhu Yanjun wrote: >>>>> 在 2023/5/26 13:46, Liang Chen 写道: >>>> what made you respond to a patch from May, now? >>> I want to apply page_pool to our virtio_net. This virtio_net works on >>> our device. >>> >>> I want to verify whether page_pool on virtio_net with our device can >>> improve the performance or not. >>> >>> And I found that ethtool is wrong. >>> >>> I use virtio_net on our device. I found that page member variable in >>> rq is not used in recv path. >>> >>> When virtio_net is modprobe, I checked page member variable in rq with >>> kprobe or crash tool.  page member variable in rq is always NULL. >>> >>> But sg in recv path is used. >>> >>> So how to use page member variable in rq? If page member variable in >>> rq is always NULL, can we remove it? >>> >>> BTW, I use ping and iperf tool to make tests with virtio_net. In the >>> tests, page member variable in rq is always NULL. >> >> And I replaced page member variable in rq with page_pool, but the >> statistics of page_pool are always 0. >> >> It is interesting that page_pool member variable in rq is not used in >> ping and iperf tests. >> >> I am not sure what tests can make page member variable not NULL. ^_^ > Do you mean rq->pages? > > That is for big mode. Hi, Xuan Got it. What is big mode? Do you mean big packet size? I run iperf with the packet size 2^23. The rq->pages is still NULL. It is interesting. Zhu Yanjun > > Thanks. > > >> Best Regards, >> >> Zhu Yanjun >> >> >>> It is interesting. >>> >>> Zhu Yanjun >>>