From: Johannes Berg <johannes@sipsolutions.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Marc MERLIN <marc@merlins.org>,
netdev@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
intel-wired-lan@lists.osuosl.org,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [RFC PATCH] net: ethtool: do runtime PM outside RTNL
Date: Mon, 04 Dec 2023 23:25:46 +0100 [thread overview]
Message-ID: <c4404a84e6490295a8aba37bab7d3152c44ff0ba.camel@sipsolutions.net> (raw)
In-Reply-To: <20231204142217.176ed99f@kernel.org>
On Mon, 2023-12-04 at 14:22 -0800, Jakub Kicinski wrote:
> On Mon, 04 Dec 2023 22:32:25 +0100 Johannes Berg wrote:
> > Well, I was hoping that
> >
> > (a) ethtool folks / Jakub would comment if this makes sense, but I
> > don't see a good reason to do things the other way around (other
> > than "code is simpler"); and
>
> My opinion on RPM is pretty uneducated. But taking rtnl_lock to resume
> strikes me as shortsighted. RPM functionality should be fairly
> self-contained, and deserving of a separate lock.
> Or at the very least having looked at the igc RPM code in the past,
> I'm a bit cautious about bending the core to fit it, as it is hardly
> a model...
I could agree with that. The reason it seems to do that is that it
invokes some other ifup/down related code in suspend/resume...
On the other hand it also seems a bit odd to do something as unrelated
to networking as runtime PM (which you can also trigger through various
other paths such as sysfs) under RTNL, holding RTNL for longer than
seems necessary, and creating more contention on it?
johannes
next prev parent reply other threads:[~2023-12-04 22:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 19:07 [RFC PATCH] net: ethtool: do runtime PM outside RTNL Johannes Berg
[not found] ` <20231204200038.GA9330@merlins.org>
[not found] ` <a6ac887f7ce8af0235558752d0c781b817f1795a.camel@sipsolutions.net>
2023-12-04 20:36 ` Marc MERLIN
2023-12-04 20:40 ` Johannes Berg
2023-12-04 20:54 ` Marc MERLIN
2023-12-04 21:28 ` Marc MERLIN
2023-12-04 21:32 ` Johannes Berg
2023-12-04 22:22 ` Jakub Kicinski
2023-12-04 22:25 ` Johannes Berg [this message]
2023-12-05 2:46 ` Marc MERLIN
2023-12-05 19:33 ` Johannes Berg
2023-12-05 23:15 ` Marc MERLIN
2023-12-06 9:50 ` Johannes Berg
2023-12-05 5:19 ` Przemek Kitszel
2023-12-05 19:48 ` Johannes Berg
2023-12-06 8:46 ` Przemek Kitszel
2023-12-06 9:37 ` Johannes Berg
2023-12-06 11:59 ` Heiner Kallweit
2024-01-03 8:20 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4404a84e6490295a8aba37bab7d3152c44ff0ba.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anthony.l.nguyen@intel.com \
--cc=hkallweit1@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=marc@merlins.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).