From: Heiner Kallweit <hkallweit1@gmail.com>
To: Lev Stipakov <lstipakov@gmail.com>,
Pravin B Shelar <pshelar@ovn.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, dev@openvswitch.org,
linux-kernel@vger.kernel.org
Cc: Lev Stipakov <lev@openvpn.net>
Subject: Re: [PATCH v2 2/3] net: openvswitch: use core API to update/provide stats
Date: Fri, 13 Nov 2020 11:46:18 +0100 [thread overview]
Message-ID: <c4409cfe-4d58-27da-0c0d-3c59ce508aea@gmail.com> (raw)
In-Reply-To: <20201113090240.116518-1-lev@openvpn.net>
Am 13.11.2020 um 10:02 schrieb Lev Stipakov:
> Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added
> function "dev_sw_netstats_tx_add()" to update net device per-cpu TX
> stats.
>
> Use this function instead of own code.
>
> While on it, remove internal_get_stats() and replace it
> with dev_get_tstats64().
>
> Signed-off-by: Lev Stipakov <lev@openvpn.net>
> ---
>
> v2:
> - do not delete len variable and add comment why
> - replace internal_get_stats() vs dev_get_tstats64()
>
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
next prev parent reply other threads:[~2020-11-13 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 11:11 [PATCH 2/3] net: openvswitch: use core API for updating TX stats Lev Stipakov
2020-11-13 7:40 ` Heiner Kallweit
2020-11-13 9:02 ` [PATCH v2 2/3] net: openvswitch: use core API to update/provide stats Lev Stipakov
2020-11-13 10:46 ` Heiner Kallweit [this message]
2020-11-13 21:53 ` [PATCH v3] " Lev Stipakov
2020-11-15 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4409cfe-4d58-27da-0c0d-3c59ce508aea@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=kuba@kernel.org \
--cc=lev@openvpn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lstipakov@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).