From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31D2EC56202 for ; Fri, 13 Nov 2020 10:47:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CACCB20678 for ; Fri, 13 Nov 2020 10:47:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PrlqCL+y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726429AbgKMKrX (ORCPT ); Fri, 13 Nov 2020 05:47:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726184AbgKMKrP (ORCPT ); Fri, 13 Nov 2020 05:47:15 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1603C0613D6; Fri, 13 Nov 2020 02:47:14 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id j7so9275115wrp.3; Fri, 13 Nov 2020 02:47:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=4t6Go8s2wuljbP+CKsMvEmJeK2UV1YCceUwBdC4gPWQ=; b=PrlqCL+y+Nimhok7ieyk2TVyXiDQx4yB0yRW8G1lamoNMJe8cSroQcFYXraf2MYCm2 Jc80fjDkgy7ZEBYmLK5rOpHb3s2w17ZeIKQtRTsqiDeQgplrNOxN40keYNIpXInzzoou Kc0LUE78hrq3PV2Y/yB40Ly45utldM7GHf5JCOO9JmYWlh3ZTJ3XUYJYHluOiOMnmZnJ tXAGDyvNjcCPSWAcQMVcqL71G7ajlOA2wucAkaCTfnQRGzSn7NVOK1U1KtIueR8P2X0K 13/KS6twTNx0u5M3v7Mn0GQbAN5fmSGgC+Xgh0KocPXISixJMvh1JgmqJTZ6Mqo8tv6A KtaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=4t6Go8s2wuljbP+CKsMvEmJeK2UV1YCceUwBdC4gPWQ=; b=Wfq0oU2dPVkRZOKLsMoqFg2cmQhUw94rHw/mY0Q25uShfsyQFaQ33mNuhuckCMpPFU 8CHLN5km2qB/8oqjtQhyBXzmZA2tPA8MOHd4QPAHgjrIgK7ZNKVEuB6VoNpa/Fsraai2 a/kgxmCWUN1lk7YZHYKDX2M+Jl2hOm9BsHTub3CHcCfWjKIhZ9yceD2MVjYSxiraNFSd jUSOtseGqdhpym0ZRF4wqO9LCRIIHPGq0lTbM786kNpiwP1dp7nwzc0U9LlxvWesQFj5 xH6FyNiqMaqCAMCFhkq6PG0Znjg88sszzeVRU+7Q6NWe2lRDcZ26dNRiN5G6Fb/A5HJV +upg== X-Gm-Message-State: AOAM532rrerlgtO9Uwg7Lm3YE+PFNT1JH6Lu5uvPAs2bdtGSNXmcMjNj AKCTXHxTRL9jBw4XBP6t116b3zBvQxkZrw== X-Google-Smtp-Source: ABdhPJyVWozexVIZbyTwEL+afu4k/aEzfnibs44FZG6h5upqaXD+EqnRvGGkSuG5ZUCXPb258UHcIg== X-Received: by 2002:adf:9104:: with SMTP id j4mr2871481wrj.198.1605264433404; Fri, 13 Nov 2020 02:47:13 -0800 (PST) Received: from ?IPv6:2003:ea:8f23:2800:e113:5d8d:7b96:ca98? (p200300ea8f232800e1135d8d7b96ca98.dip0.t-ipconnect.de. [2003:ea:8f23:2800:e113:5d8d:7b96:ca98]) by smtp.googlemail.com with ESMTPSA id i5sm11296099wrw.45.2020.11.13.02.47.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Nov 2020 02:47:12 -0800 (PST) Subject: Re: [PATCH v2 2/3] net: openvswitch: use core API to update/provide stats To: Lev Stipakov , Pravin B Shelar , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org Cc: Lev Stipakov References: <598c779c-fb0b-a9a6-43be-3a7cd5b38946@gmail.com> <20201113090240.116518-1-lev@openvpn.net> From: Heiner Kallweit Message-ID: Date: Fri, 13 Nov 2020 11:46:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201113090240.116518-1-lev@openvpn.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Am 13.11.2020 um 10:02 schrieb Lev Stipakov: > Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added > function "dev_sw_netstats_tx_add()" to update net device per-cpu TX > stats. > > Use this function instead of own code. > > While on it, remove internal_get_stats() and replace it > with dev_get_tstats64(). > > Signed-off-by: Lev Stipakov > --- > > v2: > - do not delete len variable and add comment why > - replace internal_get_stats() vs dev_get_tstats64() > Reviewed-by: Heiner Kallweit