From: David Ahern <dsahern@kernel.org>
To: Guillaume Nault <gnault@redhat.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, Taras Chornyi <tchornyi@marvell.com>,
Ido Schimmel <idosch@nvidia.com>, Petr Machata <petrm@nvidia.com>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH net-next 1/5] ipv4: Use dscp_t in struct fib_rt_info
Date: Sun, 10 Apr 2022 11:58:43 -0600 [thread overview]
Message-ID: <c4626f31-f986-b4e3-f72d-8faacafe565d@kernel.org> (raw)
In-Reply-To: <027027eb31686b0ea43aaf6e533a5912ca400f21.1649445279.git.gnault@redhat.com>
On 4/8/22 2:08 PM, Guillaume Nault wrote:
> Use the new dscp_t type to replace the tos field of struct fib_rt_info.
> This ensures ECN bits are ignored and makes it compatible with the
> fa_dscp field of struct fib_alias.
>
> This also allows sparse to flag potential incorrect uses of DSCP and
> ECN bits.
>
> Signed-off-by: Guillaume Nault <gnault@redhat.com>
> ---
> drivers/net/ethernet/marvell/prestera/prestera_router.c | 3 ++-
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 7 ++++---
> drivers/net/netdevsim/fib.c | 5 +++--
> include/net/ip_fib.h | 2 +-
> net/ipv4/fib_semantics.c | 4 ++--
> net/ipv4/fib_trie.c | 6 +++---
> net/ipv4/route.c | 4 ++--
> 7 files changed, 17 insertions(+), 14 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2022-04-10 17:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 20:08 [PATCH net-next 0/5] ipv4: Convert several tos fields to dscp_t Guillaume Nault
2022-04-08 20:08 ` [PATCH net-next 1/5] ipv4: Use dscp_t in struct fib_rt_info Guillaume Nault
2022-04-10 17:01 ` Ido Schimmel
2022-04-10 17:58 ` David Ahern [this message]
2022-04-08 20:08 ` [PATCH net-next 2/5] ipv4: Use dscp_t in struct fib_entry_notifier_info Guillaume Nault
2022-04-10 17:01 ` Ido Schimmel
2022-04-10 17:59 ` David Ahern
2022-04-08 20:08 ` [PATCH net-next 3/5] netdevsim: Use dscp_t in struct nsim_fib4_rt Guillaume Nault
2022-04-09 3:38 ` Jakub Kicinski
2022-04-10 17:02 ` Ido Schimmel
2022-04-10 18:00 ` David Ahern
2022-04-08 20:08 ` [PATCH net-next 4/5] mlxsw: Use dscp_t in struct mlxsw_sp_fib4_entry Guillaume Nault
2022-04-10 17:02 ` Ido Schimmel
2022-04-08 20:08 ` [PATCH net-next 5/5] net: marvell: prestera: Use dscp_t in struct prestera_kern_fib_cache Guillaume Nault
2022-04-11 15:09 ` Yevhen Orlov
2022-04-12 1:20 ` [PATCH net-next 0/5] ipv4: Convert several tos fields to dscp_t patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4626f31-f986-b4e3-f72d-8faacafe565d@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=gnault@redhat.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=tchornyi@marvell.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).