Netdev List
 help / color / mirror / Atom feed
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Markus Elfring <Markus.Elfring@web.de>,
	netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>,
	Jonas Gorski <jonas.gorski@gmail.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Vladimir Oltean <olteanv@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: bcm_sf2: Use devm_clk_get_optional_enabled() in bcm_sf2_sw_probe()
Date: Thu, 19 Nov 2026 13:06:09 -0800	[thread overview]
Message-ID: <c4715b1f-c2cc-4b4f-8610-dd2e0ec71c45@broadcom.com> (raw)
In-Reply-To: <92093067-f11e-4ce8-af0e-698644dc27ba@wanadoo.fr>

On 11/19/26 12:21, Christophe JAILLET wrote:
> Le 19/11/2026 à 17:37, Markus Elfring a écrit :
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Thu, 19 Nov 2026 17:30:09 +0100
>>
>> Reuse existing functionality from devm_clk_get_optional_enabled()
>> instead of keeping duplicate source code.
>>
>> The source code was transformed by using the Coccinelle software.
>>
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>> ---
>>   drivers/net/dsa/bcm_sf2.c | 6 +-----
>>   1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
>> index 1747a1f20c78..011ce79392e8 100644
>> --- a/drivers/net/dsa/bcm_sf2.c
>> +++ b/drivers/net/dsa/bcm_sf2.c
>> @@ -1467,14 +1467,10 @@ static int bcm_sf2_sw_probe(struct 
>> platform_device *pdev)
>>           base++;
>>       }
>> -    priv->clk = devm_clk_get_optional(&pdev->dev, "sw_switch");
>> +    priv->clk = devm_clk_get_optional_enabled(&pdev->dev, "sw_switch");
>>       if (IS_ERR(priv->clk))
>>           return PTR_ERR(priv->clk);
>> -    ret = clk_prepare_enable(priv->clk);
>> -    if (ret)
>> -        return ret;
>> -
>>       priv->clk_mdiv = devm_clk_get_optional(&pdev->dev, 
>> "sw_switch_mdiv");
>>       if (IS_ERR(priv->clk_mdiv)) {
>>           ret = PTR_ERR(priv->clk_mdiv);
> 
> Hi,
> 
> NACK, this patch is wrong because the remove function and the error 
> handling path of the probe need to be updated.

My bad you are right this creates the following regressions: 
devm_clk_get_optional_enabled() registers a devres action that calls 
clk_disable_unprepare() on detach. The patch leaves the manual
clk_disable_unprepare(priv->clk) in two places in 
drivers/net/dsa/bcm_sf2.c: the probe error path (out_clk:) and 
bcm_sf2_sw_remove().

pw-bot: cr
-- 
Florian

      reply	other threads:[~2026-11-19 21:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 16:37 [PATCH net-next] net: dsa: bcm_sf2: Use devm_clk_get_optional_enabled() in bcm_sf2_sw_probe() Markus Elfring
2026-11-19 17:45 ` Florian Fainelli
2026-11-19 20:21 ` Christophe JAILLET
2026-11-19 21:06   ` Florian Fainelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4715b1f-c2cc-4b4f-8610-dd2e0ec71c45@broadcom.com \
    --to=florian.fainelli@broadcom.com \
    --cc=Markus.Elfring@web.de \
    --cc=andrew@lunn.ch \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=jonas.gorski@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox