From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: Re: [PATCH net-next] sysfs: Fix regression when adding a file to an existing group Date: Sat, 28 Jul 2018 17:47:08 +0200 Message-ID: References: <1532727207-10912-1-git-send-email-tyhicks@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Greg Kroah-Hartman , Dmitry Torokhov , linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Tyler Hicks , "David S. Miller" Return-path: In-Reply-To: <1532727207-10912-1-git-send-email-tyhicks@canonical.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 27.07.2018 23:33, Tyler Hicks wrote: > Commit 5f81880d5204 ("sysfs, kobject: allow creating kobject belonging > to arbitrary users") incorrectly changed the argument passed as the > parent parameter when calling sysfs_add_file_mode_ns(). This caused some > sysfs attribute files to not be added correctly to certain groups. > > Fixes: 5f81880d5204 ("sysfs, kobject: allow creating kobject belonging to arbitrary users") > Signed-off-by: Tyler Hicks > Reported-by: Heiner Kallweit > --- > > Note, this was a regression exclusively in linux-next and never made it to > Linus' tree. There's no need to queue it up for linux-stable. > > fs/sysfs/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c > index fa46216523cf..052e5ad9a4d2 100644 > --- a/fs/sysfs/file.c > +++ b/fs/sysfs/file.c > @@ -373,7 +373,7 @@ int sysfs_add_file_to_group(struct kobject *kobj, > return -ENOENT; > > kobject_get_ownership(kobj, &uid, &gid); > - error = sysfs_add_file_mode_ns(kobj->sd, attr, false, > + error = sysfs_add_file_mode_ns(parent, attr, false, > attr->mode, uid, gid, NULL); > kernfs_put(parent); > > Tested-by: Heiner Kallweit