From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: Julian Braha <julianbraha@gmail.com>,
maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
Frank.Li@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Cc: linusw@kernel.org, kees@kernel.org, colin.i.king@gmail.com,
rosenp@gmail.com, joao@joaoff.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] powerpc: remove dead 440SP code
Date: Mon, 17 Aug 2026 08:29:06 +0200 [thread overview]
Message-ID: <c4d970dd-cb54-4530-9491-01b6d90e4a2b@kernel.org> (raw)
In-Reply-To: <20260816125615.985387-1-julianbraha@gmail.com>
Le 16/08/2026 à 14:56, Julian Braha a écrit :
> The 440SP config option can never be enabled, making all references to it
> dead code.
>
> Let's remove support for 440SP, since nobody can be using it anyway.
>
> This dead code was found by kconfirm, a static analysis tool for Kconfig.
It would be good to include history in the commit description:
As far as I can see, users of CONFIG_440SP were commented out by commit
f65573314e4e ("[POWERPC] Re-organize Kconfig code for 4xx in
arch/powerpc") and removed by commit ff5f483f3091 ("powerpc: 4xx: remove
commented out Kconfig entries")
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
> arch/powerpc/boot/cuboot-katmai.c | 2 +-
> arch/powerpc/include/asm/async_tx.h | 2 +-
> arch/powerpc/include/asm/dcr-regs.h | 10 +++++-----
> arch/powerpc/kernel/cpu_specs_44x.h | 12 ------------
> arch/powerpc/platforms/44x/Kconfig | 3 ---
> drivers/dma/Kconfig | 2 +-
> drivers/dma/ppc4xx/adma.c | 9 ---------
> drivers/dma/ppc4xx/adma.h | 2 +-
> drivers/dma/ppc4xx/dma.h | 9 ---------
> drivers/net/ethernet/ibm/emac/mal.h | 2 +-
> 10 files changed, 10 insertions(+), 43 deletions(-)
>
> diff --git a/arch/powerpc/boot/cuboot-katmai.c b/arch/powerpc/boot/cuboot-katmai.c
> index 034a748fde24..fcd71e76309f 100644
> --- a/arch/powerpc/boot/cuboot-katmai.c
> +++ b/arch/powerpc/boot/cuboot-katmai.c
> @@ -31,7 +31,7 @@ static void katmai_fixups(void)
> {
> unsigned long sysclk = 33333000;
>
> - /* 440SP Clock logic is all but identical to 440GX
> + /* 440SPe Clock logic is all but identical to 440GX
> * so we just use that code for now at least
> */
> ibm440spe_fixup_clocks(sysclk, 6 * 1843200, 0);
> diff --git a/arch/powerpc/include/asm/async_tx.h b/arch/powerpc/include/asm/async_tx.h
> index a14758426dd5..1ff5b2ca3ed1 100644
> --- a/arch/powerpc/include/asm/async_tx.h
> +++ b/arch/powerpc/include/asm/async_tx.h
> @@ -7,7 +7,7 @@
> #ifndef _ASM_POWERPC_ASYNC_TX_H_
> #define _ASM_POWERPC_ASYNC_TX_H_
>
> -#if defined(CONFIG_440SPe) || defined(CONFIG_440SP)
> +#if defined(CONFIG_440SPe)
Replace by #ifdef CONFIG_440SPe
> extern struct dma_chan *
> ppc440spe_async_tx_find_best_channel(enum dma_transaction_type cap,
> struct page **dst_lst, int dst_cnt, struct page **src_lst,
prev parent reply other threads:[~2026-08-17 6:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-16 12:56 [PATCH] powerpc: remove dead 440SP code Julian Braha
2026-08-17 6:29 ` Christophe Leroy (CS GROUP) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4d970dd-cb54-4530-9491-01b6d90e4a2b@kernel.org \
--to=chleroy@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joao@joaoff.com \
--cc=julianbraha@gmail.com \
--cc=kees@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox