From: David Ahern <dsahern@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>,
Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
sthemmin@microsoft.com, mlxsw@mellanox.com
Subject: Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces
Date: Wed, 31 Jul 2019 13:41:10 -0600 [thread overview]
Message-ID: <c4f83be2-adee-1595-f241-de4c26ea55ca@gmail.com> (raw)
In-Reply-To: <20190731192627.GB2324@nanopsycho>
On 7/31/19 1:26 PM, Jiri Pirko wrote:
> Wed, Jul 31, 2019 at 12:39:52AM CEST, jakub.kicinski@netronome.com wrote:
>> On Tue, 30 Jul 2019 10:57:32 +0200, Jiri Pirko wrote:
>>> From: Jiri Pirko <jiri@mellanox.com>
>>>
>>> All devlink instances are created in init_net and stay there for a
>>> lifetime. Allow user to be able to move devlink instances into
>>> namespaces.
>>>
>>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>>
>> I'm no namespace expert, but seems reasonable, so FWIW:
>>
>> Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>>
>> If I read things right we will only send the devlink instance
>> notification to other namespaces when it moves, but not
>> notifications for sub-objects like ports. Is the expectation
>> that the user space dumps the objects it cares about or will
>> the other notifications be added as needed (or option 3 - I
>> misread the code).
>
> You are correct. I plan to take care of the notifications of all objects
> in the follow-up patchset. But I can do it in this one if needed. Up to
> you.
>
seems like it should be a part of this one. If a devlink instance
changes namespaces, all of its associated resources should as well.
Also, seems like you are missing a 'can this devlink instance be moved'
check. e.g., what happens if a resource controller has been configured
for the devlink instance and it is moved to a namespace whose existing
config exceeds those limits?
next prev parent reply other threads:[~2019-07-31 19:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 8:57 [patch net-next v2 0/3] net: devlink: Finish network namespace support Jiri Pirko
2019-07-30 8:57 ` [patch net-next v2 1/3] net: devlink: allow to change namespaces Jiri Pirko
2019-07-30 22:39 ` Jakub Kicinski
2019-07-31 19:26 ` Jiri Pirko
2019-07-31 19:41 ` David Ahern [this message]
2019-07-31 19:45 ` Jiri Pirko
2019-07-31 19:46 ` David Ahern
2019-07-31 19:58 ` David Ahern
2019-07-31 20:20 ` David Ahern
2019-08-02 7:48 ` Jiri Pirko
2019-08-02 15:45 ` David Ahern
2019-08-05 5:54 ` Jiri Pirko
2019-08-05 14:10 ` David Ahern
2019-08-05 14:49 ` Jiri Pirko
2019-08-05 14:51 ` David Ahern
2019-08-05 15:20 ` Jiri Pirko
2019-08-06 17:34 ` David Ahern
2019-08-06 17:53 ` Jiri Pirko
2019-08-06 17:55 ` David Ahern
2019-08-06 18:07 ` Jiri Pirko
2019-08-02 7:43 ` Jiri Pirko
2019-07-30 8:57 ` [patch net-next v2 2/3] net: devlink: export devlink net set/get helpers Jiri Pirko
2019-07-30 22:40 ` Jakub Kicinski
2019-07-30 8:57 ` [patch net-next v2 3/3] netdevsim: create devlink and netdev instances in namespace Jiri Pirko
2019-07-30 22:40 ` Jakub Kicinski
2019-07-30 8:59 ` [patch iproute2-next v2 1/2] devlink: introduce cmdline option to switch to a different namespace Jiri Pirko
2019-07-30 8:59 ` [patch iproute2-next v2 2/2] devlink: add support for network namespace change Jiri Pirko
2019-07-31 22:59 ` [patch net-next v2 0/3] net: devlink: Finish network namespace support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4f83be2-adee-1595-f241-de4c26ea55ca@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).