From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 775CD473C65 for ; Thu, 24 Sep 2026 10:07:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790244479; cv=none; b=b6B0s1vuYbI3D5rPg492/GwIKfrRPaCFJ1bH8bwniL97tYVD982q2Kk6bMDQ64K4C5oRGy9NNquaK+dJ8qGSnlBhceRd03/s0IS6VX5wo0sFhO7EuN0+2r3tJclWdJ7QbzUWdIISc84iYEyntX1u1heMyQAIUscsEMhe/QJbqyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790244479; c=relaxed/simple; bh=oPILir9HN5MgKg08aglNg67+B4awsfF8aWsxHEYQyfY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RuGbWD8daRxEKYF2L1KhVK0MlX4LuIsmLl0yRmEumwhoPBXaFAFDCOA8+83YGdPB13uGelKUjHCSty+wZZyy4RrvwcoF252MC733RA4U5v29PfaXmB82GWHLXkVjcR+dDzXbdfwbX131wPFIh+mo0zcDI5EDNXT8FTIPA5ZEbpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aCTUEzVc; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=tAdCk7sB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aCTUEzVc"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="tAdCk7sB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790244461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RSjliNhO01y6ukOqtQMKm+Eso5qszoHcMLKfvGQmCdk=; b=aCTUEzVcLTM3XCzoKEy8y3VulNZTuuSRzzRMDE4seAUIr0cLYI4MLCZpzqEae8nsFaXsKA vLie0GYguULr4/jafeSsuTRdniLticFWV8VU1DksVKRFkEdxQ5ArjddREFBYzigBmZK1uk fXTUcmKexL+jf01QwOfD9Ig4pj575/Y= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-UZtgYcoONA6Sjlp84Oi7pg-1; Thu, 24 Sep 2026 06:07:40 -0400 X-MC-Unique: UZtgYcoONA6Sjlp84Oi7pg-1 X-Mimecast-MFC-AGG-ID: UZtgYcoONA6Sjlp84Oi7pg_1790244459 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4870eda3782so1439642f8f.0 for ; Thu, 24 Sep 2026 03:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1790244459; x=1790849259; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RSjliNhO01y6ukOqtQMKm+Eso5qszoHcMLKfvGQmCdk=; b=tAdCk7sBw2nECCbqlxxniD1gnGwLnT66RJx9BqzkO1/GkvZQyt4M/3yiX8/KknM6M8 7vV6ZHF8jev0DxYNvTANWHrevbXKpS6M4R4kDjlEU6RZM3Q+7aWzbSpOolpKdfU474f0 YHVUI5hH+QvPV/JF+96neaBwqnlLw1gGp/gyVHIoziKEQVwkjhKRIisGL2AV0hlVHi0i 1feMl1xxH+aKYhmouwqFWrEdSoIrvXH+2FcuEGbX8qayHcL3siO8BsKBNFTehwo8L+Wd AOYdpIXKsHs8R7d22wnbR23jtO4tiO05fNi5hwWbc5QfbkwblpYxtPsVZo42O05O+mWc ad7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790244459; x=1790849259; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RSjliNhO01y6ukOqtQMKm+Eso5qszoHcMLKfvGQmCdk=; b=GbusOKjOgH9XH8AE977gCNi/eZ/DsXWBV5G8yy696SmpVB3r5brW9Xc+m+W8Img8fN p0e+YsvihHMSPv90fHCA/9hx8RRfyYLeenY4uay/S8SoN9NRyHDjL87k6rCUUGkq14UN 42N/hfGB38MrXsAQv47qafRWq/Eg4QaJfyONwRI2eyGcaWLIfNpObYvkJiI3hGWYi2VF g9kSb6YdtyHJHMtNO6wc1Bd3AN3iRNYY3xbumLzF2j5bRWoVGhS9SZpFxqgnDGWLtkjE eDtIlrPYiktOHhiH3qeYfBMOYL5tDgD6+J0GP7GBvhsPEqAhrFYKlFUpieNzpavlJm0g RY+Q== X-Gm-Message-State: AFuF++mdHPGvxFyu6s2b7MiT0JSmTGBLf/1bVI671BRc3royuRIwohiF BZvSqFnp95YthU7cXiPanaOWq8O/FW29tEnSyf0WqghGYP4eVKYFh7hri8fAuRGU/L/udY4EXh0 vDZ2SmCJITtZ3mIlusxUf6Rnrn2v2vFBzKozqCDt6sCiM3lSPAKUuzYRBlA== X-Gm-Gg: AYBFou27lHY/x4xjsJ7zGcjxSumzjxpetGK2uOzslMIC/zE+XN37u2veftHtSJpWb2G 7XDYIaom/8jQ1rMvbZ4tegcRIEwPN+jfZKlvWZaDowYGTLuEF6efDljpKX/4PyHTMgeBZYDXfGM Kmh/BBk9MNQRiQHMt5UKBcdXSHswqxUzFBuVEDRJG4YTznIARVSl+vtmXg7Yln0UdxuSRRyQl1J oMuLahDxDYY42IMLEgOOkiVzyRJKpdXB1HTmuFT33weIBP1PvdHPim3L+URlyrHbaj0W86I1NWK TBBqs89dWtKkM3eX9vagred8vTl5+vAwL/HZ2Rw76HB9Kt7DQqI8PZFloZN3jLF+Q1giLRfX8kW Kbulipp12GL3ZuDfk2UhLNoSBUriEu44WD69S+f5qTj7DkMk/YaRb2rpb54A= X-Received: by 2002:a05:6000:4282:b0:486:e9ab:2b86 with SMTP id ffacd0b85a97d-48871759fd6mr3193148f8f.39.1790244459299; Thu, 24 Sep 2026 03:07:39 -0700 (PDT) X-Received: by 2002:a05:6000:4282:b0:486:e9ab:2b86 with SMTP id ffacd0b85a97d-48871759fd6mr3193104f8f.39.1790244458892; Thu, 24 Sep 2026 03:07:38 -0700 (PDT) Received: from [192.168.188.234] (ip232-47-231-195.pool-bba.aruba.it. [195.231.47.232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48868779472sm14003920f8f.23.2026.09.24.03.07.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Sep 2026 03:07:38 -0700 (PDT) Message-ID: Date: Thu, 24 Sep 2026 12:07:37 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v14 0/7] r8169: add RSS support for RTL8127 To: javen , hkallweit1@gmail.com, nic_swsd@realtek.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260918061923.313-1-javen_xu@realsil.com.cn> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260918061923.313-1-javen_xu@realsil.com.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/18/26 08:19, javen wrote: > From: Javen Xu > > This patch series adds RSS (Receive Side Scaling) support for the r8169 > ethernet driver, specifically for RTL8127 (RTL_GIGA_MAC_VER_80). > > RSS enables packet distribution across multiple receive queues, which can > significantly improve network throughput on multi-core systems by allowing > parallel processing of incoming packets. > > Key features: > - Multi-queue RX support (up to 8 queues) > - MSI-X interrupt with vector mapping > - Dynamic queue configuration via ethtool (-L) > - RSS hash computation for flow classification > > Experiments: > Platform: AMD Ryzen Embedded R2514 with Radeon Graphics(4 Cores/8 Threads) > Arch: x86_64 > Test command: > Server: iperf3 -s > Client: iperf3 -c 192.168.2.1 -P 20 -t 3600 > Monitor: mpstat -P ALL 1 > > Before this patch (Without RSS): > Throughput: Unstable, fluctuating between 3.76 Gbits/sec and > 8.2 Gbits/sec. > CPU Usage: A single CPU core is fully occupied with softirq reaching > up to 96%. > > After this patch (With RSS enabled): > Throughput: Stable at 9.42 Gbits/sec. > CPU Usage: The traffic load is evenly distributed across multiple CPU > cores. The maximum softirq on a single core dropped to 63%. > > Other Experiments: > Link: https://lore.kernel.org/netdev/0A5279953D81BB9C+f50c9b49-3e5d-467f-b69a-7e49ed223383@radxa.com/ The API usage changes suggested by clashiko on patch 3/7 should be IMHO be addressed even if marked 'low prio' (IMHO clashiko mislabeled them). The claim about the fixes tag on patch 5/7 can instead IMHO be ignored, but on the same patch clashiko reports more low prio issues that again should be addressed. /P