Netdev List
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Zahari Doychev <zahari.doychev@linux.com>, netdev@vger.kernel.org
Cc: simon.horman@netronome.com, jhs@mojatatu.com, jianbol@mellanox.com
Subject: Re: [PATCH iproute2-next v2] tc flower: use right ethertype in icmp/arp parsing
Date: Fri, 13 Nov 2020 20:12:19 -0700	[thread overview]
Message-ID: <c51abdae-6596-54ec-2b96-9b010c27cdb1@gmail.com> (raw)
In-Reply-To: <20201110075355.52075-1-zahari.doychev@linux.com>

On 11/10/20 12:53 AM, Zahari Doychev wrote:
> Currently the icmp and arp parsing functions are called with incorrect
> ethtype in case of vlan or cvlan filter options. In this case either
> cvlan_ethtype or vlan_ethtype has to be used. The ethtype is now updated
> each time a vlan ethtype is matched during parsing.
> 
> Signed-off-by: Zahari Doychev <zahari.doychev@linux.com>
> ---
>  tc/f_flower.c | 52 +++++++++++++++++++++++----------------------------
>  1 file changed, 23 insertions(+), 29 deletions(-)
> 

Thanks, looks much better.

applied to iproute2-next.


  reply	other threads:[~2020-11-14  3:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10  7:53 [PATCH iproute2-next v2] tc flower: use right ethertype in icmp/arp parsing Zahari Doychev
2020-11-14  3:12 ` David Ahern [this message]
2020-11-24  9:39   ` Roi Dayan
2020-11-24 12:13     ` Roi Dayan
2020-11-24 13:41       ` Jamal Hadi Salim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c51abdae-6596-54ec-2b96-9b010c27cdb1@gmail.com \
    --to=dsahern@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=jianbol@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=simon.horman@netronome.com \
    --cc=zahari.doychev@linux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox