From: Vincent Mailhol <mailhol@kernel.org>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
"Jakub Kicinski" <kuba@kernel.org>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Kory Maincent" <kory.maincent@bootlin.com>,
"Jacob Keller" <jacob.e.keller@intel.com>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"Stefan Mätje" <stefan.maetje@esd.eu>,
socketcan@esd.eu, "Manivannan Sadhasivam" <mani@kernel.org>,
"Thomas Kopp" <thomas.kopp@microchip.com>,
"Oliver Hartkopp" <socketcan@hartkopp.net>,
"Jimmy Assarsson" <extja@kvaser.com>,
"Axel Forsman" <axfo@kvaser.com>
Subject: Re: [PATCH net-next 0/3] convert can drivers to use ndo_hwtstamp callbacks
Date: Thu, 30 Oct 2025 07:36:52 +0100 [thread overview]
Message-ID: <c544fdee-5b66-45dd-b3bb-75dfd8e1adc4@kernel.org> (raw)
In-Reply-To: <20251029231620.1135640-1-vadim.fedorenko@linux.dev>
Hi Vadim,
On 30/10/2025 at 00:16, Vadim Fedorenko wrote:
> The patchset converts generic ioctl implementation into a pair of
> ndo_hwtstamp_get/ndo_hwtstamp_set generic callbacks and replaces
> callbacks in drivers.
Thanks for the series. I wasn't aware of the ndo_hwtstamp_{get,set}()
when I wrote the original series. The code looks nicer like this
without the need to use the copy_{from,to}_user() anymore.
I do not have access to my hardware at the moment, so I can not
test. But the code looks straightforward to me, so:
Reviewed-by: Vincent Mailhol <mailhol@kernel.org>
Yours sincerely,
Vincent Mailhol
next prev parent reply other threads:[~2025-10-30 6:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 23:16 [PATCH net-next 0/3] convert can drivers to use ndo_hwtstamp callbacks Vadim Fedorenko
2025-10-29 23:16 ` [PATCH net-next 1/3] can: convert generic HW timestamp ioctl to " Vadim Fedorenko
2025-10-30 17:01 ` Kory Maincent
2025-10-29 23:16 ` [PATCH net-next 2/3] can: peak_canfd: convert to use " Vadim Fedorenko
2025-10-30 17:04 ` Kory Maincent
2025-10-29 23:16 ` [PATCH net-next 3/3] can: peak_usb: " Vadim Fedorenko
2025-10-30 17:05 ` Kory Maincent
2025-10-30 6:36 ` Vincent Mailhol [this message]
2025-10-31 12:19 ` [PATCH net-next 0/3] convert can drivers " Marc Kleine-Budde
2025-11-12 8:45 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c544fdee-5b66-45dd-b3bb-75dfd8e1adc4@kernel.org \
--to=mailhol@kernel.org \
--cc=axfo@kvaser.com \
--cc=extja@kvaser.com \
--cc=jacob.e.keller@intel.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@esd.eu \
--cc=socketcan@hartkopp.net \
--cc=stefan.maetje@esd.eu \
--cc=thomas.kopp@microchip.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).