From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C74818C17 for ; Mon, 31 Jul 2023 15:08:48 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECF4910EB; Mon, 31 Jul 2023 08:08:46 -0700 (PDT) Message-ID: Date: Mon, 31 Jul 2023 11:08:41 -0400 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [PATCH 3/5] rtc: ds1685: use EXPORT_SYMBOL_GPL for ds1685_rtc_poweroff Content-Language: en-US To: Christoph Hellwig , Luis Chamberlain , Greg Kroah-Hartman , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Ulf Hansson , Yangbo Lu Cc: Daniel Vetter , linux-arm-kernel@lists.infradead.org, open list , linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-modules@vger.kernel.org References: <20230731083806.453036-1-hch@lst.de> <20230731083806.453036-4-hch@lst.de> From: Joshua Kinard In-Reply-To: <20230731083806.453036-4-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 7/31/2023 04:38, Christoph Hellwig wrote: > ds1685_rtc_poweroff is only used externally via symbol_get, which was > only ever intended for very internal symbols like this one. Use > EXPORT_SYMBOL_GPL for it so that symbol_get can enforce only being used > on EXPORT_SYMBOL_GPL symbols. > > Signed-off-by: Christoph Hellwig > --- > drivers/rtc/rtc-ds1685.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c > index 0f707be0eb87fa..04dbf35cf3b706 100644 > --- a/drivers/rtc/rtc-ds1685.c > +++ b/drivers/rtc/rtc-ds1685.c > @@ -1432,7 +1432,7 @@ ds1685_rtc_poweroff(struct platform_device *pdev) > unreachable(); > } > } > -EXPORT_SYMBOL(ds1685_rtc_poweroff); > +EXPORT_SYMBOL_GPL(ds1685_rtc_poweroff); > /* ----------------------------------------------------------------------- */ > > Acked-by: Joshua Kinard