From: Christian Lamparter <chunkeey@gmail.com>
To: netdev-bot+sashiko@kernel.org
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch, kuba@kernel.org,
davem@davemloft.net
Subject: Re: [PATCH net v1] net: emac: move setting of netops to fix crash
Date: Mon, 21 Sep 2026 17:55:21 +0200 [thread overview]
Message-ID: <c557d239-d0e5-4b67-be69-f1c05a913cda@gmail.com> (raw)
In-Reply-To: <178999551085.2160803.13630958553679103031@kernel.org>
On 9/21/26 2:58 PM, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
>
> Critical: 0 · High: 1 · Medium: 0 · Low: 0
>
> - [High] In `emac_probe()` (drivers/net/ethernet/ibm/emac/core.c) the
> relocated Gigabit branch now sets `dev->commac.ops =…
>
>
> Would it be enough to hoist only ndev->netdev_ops and ndev->ethtool_ops,
> which is what the netdev_need_ops_lock() check in phy_link_topo_add_phy()
> needs before of_phy_connect(), and leave the commac.ops selection where it
> was, or alternatively set dev->commac.ops = &emac_commac_ops only in the
> non-gige case?
> --
Oh yes. I see, thanks. I'll send a v2.
Cheers,
Christian
--
pw-bot: cr
prev parent reply other threads:[~2026-09-21 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 11:34 [PATCH net v1] net: emac: move setting of netops to fix crash Christian Lamparter
2026-09-21 12:58 ` netdev-bot+sashiko
2026-09-21 15:55 ` Christian Lamparter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c557d239-d0e5-4b67-be69-f1c05a913cda@gmail.com \
--to=chunkeey@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox