From mboxrd@z Thu Jan 1 00:00:00 1970 From: Edward Cree Subject: Re: [PATCH v3 net-next 7/9] net: ipv4: listified version of ip_rcv Date: Mon, 2 Jul 2018 15:59:49 +0100 Message-ID: References: <419314b8-1fa0-15e6-794d-5ef8874597a2@solarflare.com> <201806300522.U7RgG0z9%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: kbuild test robot , , To: Return-path: Received: from dispatch1-us1.ppe-hosted.com ([67.231.154.164]:32906 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752177AbeGBO7z (ORCPT ); Mon, 2 Jul 2018 10:59:55 -0400 In-Reply-To: <201806300522.U7RgG0z9%fengguang.wu@intel.com> Content-Language: en-GB Sender: netdev-owner@vger.kernel.org List-ID: On 29/06/18 23:08, kbuild test robot wrote: > net//ipv4/ip_input.c: In function 'ip_sublist_rcv': >>> net//ipv4/ip_input.c:524:14: warning: passing argument 6 of 'NF_HOOK_LIST' from incompatible pointer type > head, dev, NULL, ip_rcv_finish); > ^ > In file included from include/uapi/linux/netfilter_ipv4.h:9:0, > from include/linux/netfilter_ipv4.h:7, > from net//ipv4/ip_input.c:145: > include/linux/netfilter.h:387:1: note: expected 'struct list_head *' but argument is of type 'struct net_device *' > NF_HOOK_LIST(uint8_t pf, unsigned int hook, struct net *net, struct sock *sk, > ^ > net//ipv4/ip_input.c:524:25: warning: passing argument 8 of 'NF_HOOK_LIST' from incompatible pointer type > head, dev, NULL, ip_rcv_finish); Looks like I forgot to change my stub for the CONFIG_NETFILTER=n case. Serves me right for not doing a build test in that configuration. Updated series to follow shortly. And thanks, kbuild, for catching it. -Ed