From: Eric Dumazet <eric.dumazet@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: use indirect call wrappers for skb_copy_datagram_iter()
Date: Wed, 25 Mar 2020 08:14:19 -0700 [thread overview]
Message-ID: <c56fe143-9229-59a4-1bbd-ab08bf496dcb@gmail.com> (raw)
In-Reply-To: <ace8e72488fbf2473efaed9fc0680886897939ab.camel@redhat.com>
On 3/25/20 4:52 AM, Paolo Abeni wrote:
>
> I wondered if we could add a second argument for
> 'csum_and_copy_to_iter', but I guess that is a slower path anyway and
> more datapoint would be needed. The patch LGTM, thanks!
Yes, TCP would not need the csum stuff, I suspect the only users
of csum would avoid one indirect call per system call at most,
that is pure noise.
While TCP right now can trigger 45 indirect calls per skb copied to user space,
assuming standard 1500 bytes MTU.
>
> Acked-by: Paolo Abeni <pabeni@redhat.com>
Thanks !
next prev parent reply other threads:[~2020-03-25 15:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 2:23 [PATCH net-next] net: use indirect call wrappers for skb_copy_datagram_iter() Eric Dumazet
2020-03-25 4:22 ` Eric Dumazet
2020-03-25 11:52 ` Paolo Abeni
2020-03-25 14:55 ` Willem de Bruijn
2020-03-25 16:00 ` Paolo Abeni
2020-03-25 16:07 ` Eric Dumazet
2020-03-25 16:24 ` Paolo Abeni
[not found] ` <CANn89iKotU9Tkd6KBgyicHFV72K9gZ+eeKwkPU097=gZZYCjrA@mail.gmail.com>
2020-03-25 16:46 ` Eric Dumazet
2020-03-25 20:58 ` Willem de Bruijn
2020-03-25 15:14 ` Eric Dumazet [this message]
2020-03-25 18:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c56fe143-9229-59a4-1bbd-ab08bf496dcb@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).