From: Nick <vincent@systemli.org>
To: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Subject: Re: ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt
Date: Wed, 25 Jan 2023 12:26:14 +0100 [thread overview]
Message-ID: <c582757f-a633-3958-d72e-e606e43879db@systemli.org> (raw)
In-Reply-To: <77b6a4f9-be34-c1c6-9140-a39633fe4692@gmail.com>
Indeed, it is fixed by those patches. Thanks! Why are they still not merged?
On 1/25/23 00:28, Florian Fainelli wrote:
> On 12/27/22 07:23, Nick wrote:
>> Commit 1fa60003a8b8 ("misc: header includes cleanup") [0] introduces
>> "-D_POSIX_C_SOURCE=200809L".
>> However, this breaks compilation with OpenWrt resulting in following
>> error:
>>
>>> marvell.c: In function 'dump_queue':
>>> marvell.c:34:17: error: unknown type name 'u_int32_t'
>>> 34 | u_int32_t ctl;
>>> | ^~~~~~~~~
>> Not sure, why the code uses u_int32_t.
>
> Should be fixed with:
>
> https://lore.kernel.org/netdev/20230114163411.3290201-1-f.fainelli@gmail.com/T/
>
next prev parent reply other threads:[~2023-01-25 11:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 15:23 ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt Nick
2023-01-24 23:11 ` Nick
2023-01-24 23:28 ` Florian Fainelli
2023-01-25 11:26 ` Nick [this message]
2023-01-27 0:10 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c582757f-a633-3958-d72e-e606e43879db@systemli.org \
--to=vincent@systemli.org \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox