From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE25F1DF252 for ; Tue, 30 Sep 2025 05:28:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759210136; cv=none; b=nv/1YJkjLe5S8yHFzAB5qwqQO2tAdDATQUkAPCddIYSb4hmSROU7xBRnKgtyVt4pu3FunAQLwnE9eghc2DyWpi/sd+jde2G9+NUExPwxspAHyBsoJZOzR+HhU9sNdPF7OiHMHY1maAW2LQXARMJXZbNGLjz28Th3d7n1/HqoqZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759210136; c=relaxed/simple; bh=cu4heVIxO6/Gw30m2J8LhrzxQEa4oV8ULkQnVzcdOX0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jIjAQiyZ51ceXXYUY78YkwL4uOrUjWsOshqd/Zt6zYiL2CE9VLK6IqgchDtKb425mV/Hg4o1/0qAxcDIu0LTrHJkwwp4elDPdmYzxL7JtaaFTRGvIgFdBy4O6kgt4jalslWtXAyVVvUsLq2aufiXrcXTr8/7+jYvmlEcECco2XE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WThhG8A6; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WThhG8A6" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-46e4ad36541so28803715e9.0 for ; Mon, 29 Sep 2025 22:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759210133; x=1759814933; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iXNttZqPfS4fimtYdIOocfzVnEBcLheGLZV8R8gaHeg=; b=WThhG8A6sWS1yiiF3oXVOl9DhJUASL9Y6pjVkDU9s9eiti3BvTL5o2LgJCX84kd93H pIp6X45xVXi0j1kq47d3nQgn+H1IyhIDhQV7NiT6fil0fZNgx0FlPJ0KiSH/xRLZvFWu LFxdToF+sn3zHhHfk0uKok3O/+OfPymBNOmhZdqmhq8qgXV0lixtsvbtrpg22GWi59vR 4wkI5yhOBoMB7an6tnKfHwPyCVVpg7bS25zrreBERz64xyDExc0Tku6Aw3u8vPPmllNU Y/ZNpM7h4IBNL+ERrkqgch+ZnH1HHR73JKGxxtIC3gVE61PgSzgZQv1inrVfuZvECKZf o1/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759210133; x=1759814933; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iXNttZqPfS4fimtYdIOocfzVnEBcLheGLZV8R8gaHeg=; b=NnqwXrK0h57HNHBu9iuqgUBcxDw7iWjHk+Bj8FiOVArQ5+lrnVQG4yDbWDCWHVnGnj X9alYlIWLiYF5ip8UaaIOiPJMnLQSzWm6Oe6JwHV+kMQZflgV9nnzI3RCfqVd31SFyso MoJSpol2NSJf3WVTW8rBqGGwWlf+DfTSxwbeecDN7TLEKTpCUT5/FsV+wpZRWQVE7m+3 NkG6LWPI9oUyDNgQy3+klF+cBPR8I9+i20ghqGZ45lNhbNVFLFBHqUvnTsFL23icCdgy n8rNynCTT0B04jaIvGUnTjWH/3FQ4jdWd5YlxOAsolJ4gr7CIxQy22i3l71qWRd/75ND PwCg== X-Gm-Message-State: AOJu0Yy3x3RtJepbUplLvMXRCZiFB4/1tdUeNMWANdeLt95ovYFHcoh/ RWHJXVZx11iQlx60FqGNSPeEYy1rWb/ozS/SjuudwMeHnrRu3zGetpUUA1j6RA== X-Gm-Gg: ASbGnctzfHMtLiBNKWEciHVwIotEKMjL7ld8HyCJBfMRsm2MHx2JX9+ut1xfCtW29Tf EOYW/sQzn2dtNjecdu7JoDrHv1hXAKGICatcsMITtRAw1zgs+/k1Llz+eOGcRJ5SeFvFrpIKWdm PPy2ZnOuy74UrQzQ5OEXL2ATzvlrqZ5bVjSNTmtYQ4A/xPszR/B+vnG+v5HzPW9stYloxzRjvBE w/wUkdvdkipebGDZaaKXiN6/atTZKmHkHn9R6lzE0nxJvkoMDPsixbg+haEc9WpqH55kESAFrzv lA9XC9VvyBz/thMinOJL0HT8tTWbVz4DtW2fPMw9gLDj+NWURoGu9NsNDGXp09+UqmozLoBGN1d N5uFw4/fBsgB58ztgc+0B3Arp8ueS6dtTFDFLs4uKSMEM9x2wQeiRz9faqSFGX0JVbw19qutz2n cfXC24 X-Google-Smtp-Source: AGHT+IGb3PutgcRprkBVcOIXuROwg6xDK7bl4CHZArC1beRvEwCGAdWq53tdEC1ZYQ/78X1RYv37bw== X-Received: by 2002:a05:600c:1394:b0:46e:1f92:49aa with SMTP id 5b1f17b1804b1-46e329c6355mr178605095e9.15.1759210132717; Mon, 29 Sep 2025 22:28:52 -0700 (PDT) Received: from [10.221.203.31] ([165.85.126.96]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e56f76b21sm38121075e9.19.2025.09.29.22.28.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Sep 2025 22:28:52 -0700 (PDT) Message-ID: Date: Tue, 30 Sep 2025 08:28:51 +0300 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] Revert "net/mlx5e: Update and set Xon/Xoff upon MTU set" To: Jakub Kicinski , davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, saeedm@nvidia.com, leon@kernel.org, tariqt@nvidia.com, mbloch@nvidia.com, alazar@nvidia.com, linux-rdma@vger.kernel.org References: <20250929181529.1848157-1-kuba@kernel.org> Content-Language: en-US From: Tariq Toukan In-Reply-To: <20250929181529.1848157-1-kuba@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29/09/2025 21:15, Jakub Kicinski wrote: > This reverts commit ceddedc969f0532b7c62ca971ee50d519d2bc0cb. > > Commit in question breaks the mapping of PGs to pools for some SKUs. > Specifically multi-host NICs seem to be shipped with a custom buffer > configuration which maps the lossy PG to pool 4. But the bad commit > overrides this with pool 0 which does not have sufficient buffer space > reserved. Resulting in ~40% packet loss. The commit also breaks BMC / > OOB connection completely (100% packet loss). > > Revert, similarly to commit 3fbfe251cc9f ("Revert "net/mlx5e: Update and > set Xon/Xoff upon port speed set""). The breakage is exactly the same, > the only difference is that quoted commit would break the NIC immediately > on boot, and the currently reverted commit only when MTU is changed. > > Note: "good" kernels do not restore the configuration, so downgrade isn't > enough to recover machines. A NIC power cycle seems to be necessary to > return to a healthy state (or overriding the relevant registers using > a custom patch). > > Fixes: ceddedc969f0 ("net/mlx5e: Update and set Xon/Xoff upon MTU set") > Signed-off-by: Jakub Kicinski > --- Reviewed-by: Tariq Toukan Thanks for your revert. We'll post fixed versions when ready. > CC: saeedm@nvidia.com > CC: leon@kernel.org > CC: tariqt@nvidia.com > CC: mbloch@nvidia.com > CC: alazar@nvidia.com > CC: linux-rdma@vger.kernel.org > ---