[PATCH net-next 1/1] ARM: dts: imx6sx: correct i.MX6sx sdb board enet phy address

[PATCH net-next 1/1] ARM: dts: imx6sx: correct i.MX6sx sdb board enet phy address

[Fugang Duan]

The commit (3d125f9c91c5) cause i.MX6SX sdb enet cannot work. The cause is
the commit add mdio node with un-correct phy address.

The patch just correct i.MX6sx sdb board enet phy address.

Signed-off-by: Fugang Duan <B38611@freescale.com>
---
 arch/arm/boot/dts/imx6sx-sdb.dts |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts b/arch/arm/boot/dts/imx6sx-sdb.dts
index 8c1febd..9db123f 100644
--- a/arch/arm/boot/dts/imx6sx-sdb.dts
+++ b/arch/arm/boot/dts/imx6sx-sdb.dts
@@ -167,11 +167,11 @@
 		#size-cells = <0>;
 
 		ethphy1: ethernet-phy@0 {
-			reg = <0>;
+			reg = <1>;
 		};
 
 		ethphy2: ethernet-phy@1 {
-			reg = <1>;
+			reg = <2>;
 		};
 	};
 };
-- 
1.7.8

Re: [PATCH net-next 1/1] ARM: dts: imx6sx: correct i.MX6sx sdb board enet phy address

[Stefan Agner]

On 2015-01-19 10:38, Fugang Duan wrote:
> The commit (3d125f9c91c5) cause i.MX6SX sdb enet cannot work. The cause is
> the commit add mdio node with un-correct phy address.

Sorry about that, somehow I did not take in consideration that that
could be different on the SoloX board.. Just checked again on Vybrid, it
is correct there, the dual PHY DP83849I addresses the two ports with 0
and 1 respectively.

> 
> The patch just correct i.MX6sx sdb board enet phy address.

Acked-by: Stefan Agner <stefan@agner.ch>

> 
> Signed-off-by: Fugang Duan <B38611@freescale.com>
> ---
>  arch/arm/boot/dts/imx6sx-sdb.dts |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts b/arch/arm/boot/dts/imx6sx-sdb.dts
> index 8c1febd..9db123f 100644
> --- a/arch/arm/boot/dts/imx6sx-sdb.dts
> +++ b/arch/arm/boot/dts/imx6sx-sdb.dts
> @@ -167,11 +167,11 @@
>  		#size-cells = <0>;
>  
>  		ethphy1: ethernet-phy@0 {
> -			reg = <0>;
> +			reg = <1>;
>  		};
>  
>  		ethphy2: ethernet-phy@1 {
> -			reg = <1>;
> +			reg = <2>;
>  		};
>  	};
>  };

Re: [PATCH net-next 1/1] ARM: dts: imx6sx: correct i.MX6sx sdb board enet phy address

[Shawn Guo]

On Mon, Jan 19, 2015 at 05:38:02PM +0800, Fugang Duan wrote:
> The commit (3d125f9c91c5) cause i.MX6SX sdb enet cannot work. The cause is
> the commit add mdio node with un-correct phy address.
> 
> The patch just correct i.MX6sx sdb board enet phy address.
> 
> Signed-off-by: Fugang Duan <B38611@freescale.com>
> ---
>  arch/arm/boot/dts/imx6sx-sdb.dts |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts b/arch/arm/boot/dts/imx6sx-sdb.dts
> index 8c1febd..9db123f 100644
> --- a/arch/arm/boot/dts/imx6sx-sdb.dts
> +++ b/arch/arm/boot/dts/imx6sx-sdb.dts
> @@ -167,11 +167,11 @@
>  		#size-cells = <0>;
>  
>  		ethphy1: ethernet-phy@0 {

The unit-address should match 'reg' property, so it needs an update too.

Shawn

> -			reg = <0>;
> +			reg = <1>;
>  		};
>  
>  		ethphy2: ethernet-phy@1 {
> -			reg = <1>;
> +			reg = <2>;
>  		};
>  	};
>  };
> -- 
> 1.7.8
> 

RE: [PATCH net-next 1/1] ARM: dts: imx6sx: correct i.MX6sx sdb board enet phy address

[fugang.duan]

From: Shawn Guo <shawn.guo@linaro.org> Sent: Tuesday, January 20, 2015 4:32 PM
> To: Duan Fugang-B38611
> Cc: davem@davemloft.net; netdev@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; s.hauer@pengutronix.de; stefan@agner.ch
> Subject: Re: [PATCH net-next 1/1] ARM: dts: imx6sx: correct i.MX6sx sdb
> board enet phy address
> 
> On Mon, Jan 19, 2015 at 05:38:02PM +0800, Fugang Duan wrote:
> > The commit (3d125f9c91c5) cause i.MX6SX sdb enet cannot work. The
> > cause is the commit add mdio node with un-correct phy address.
> >
> > The patch just correct i.MX6sx sdb board enet phy address.
> >
> > Signed-off-by: Fugang Duan <B38611@freescale.com>
> > ---
> >  arch/arm/boot/dts/imx6sx-sdb.dts |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts
> > b/arch/arm/boot/dts/imx6sx-sdb.dts
> > index 8c1febd..9db123f 100644
> > --- a/arch/arm/boot/dts/imx6sx-sdb.dts
> > +++ b/arch/arm/boot/dts/imx6sx-sdb.dts
> > @@ -167,11 +167,11 @@
> >  		#size-cells = <0>;
> >
> >  		ethphy1: ethernet-phy@0 {
> 
> The unit-address should match 'reg' property, so it needs an update too.
> 
> Shawn

Yes, you are right.
I update it and send the next version.

Thanks,
Andy