From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Ivan Vecera <ivecera@redhat.com>, netdev@vger.kernel.org
Cc: Donald Hunter <donald.hunter@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Jiri Pirko <jiri@resnulli.us>,
Prathosh Satish <Prathosh.Satish@microchip.com>,
Petr Oros <poros@redhat.com>,
linux-kernel@vger.kernel.org,
Michal Schmidt <mschmidt@redhat.com>
Subject: Re: [PATCH net-next v2 2/3] dpll: add dpll_device op to set working mode
Date: Tue, 13 Jan 2026 17:47:07 +0000 [thread overview]
Message-ID: <c5a1f45f-542e-4280-a601-ae96f2d1cac4@linux.dev> (raw)
In-Reply-To: <20260113121636.71565-3-ivecera@redhat.com>
On 13/01/2026 12:16, Ivan Vecera wrote:
> Currently, userspace can retrieve the DPLL working mode but cannot
> configure it. This prevents changing the device operation, such as
> switching from manual to automatic mode and vice versa.
>
> Add a new callback .mode_set() to struct dpll_device_ops. Extend
> the netlink policy and device-set command handling to process
> the DPLL_A_MODE attribute. Update the netlink YAML specification
> to include the mode attribute in the device-set operation.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
> v2:
> * fixed bitmap size in dpll_mode_set()
[...]
> +static int
> +dpll_mode_set(struct dpll_device *dpll, struct nlattr *a,
> + struct netlink_ext_ack *extack)
> +{
> + const struct dpll_device_ops *ops = dpll_device_ops(dpll);
> + enum dpll_mode mode = nla_get_u32(a), old_mode;
> + DECLARE_BITMAP(modes, DPLL_MODE_MAX + 1) = { 0 };
this one breaks reverse xmas tree order.
with this fixed:
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
next prev parent reply other threads:[~2026-01-13 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 12:16 [PATCH net-next v2 0/3] dpll: support mode switching Ivan Vecera
2026-01-13 12:16 ` [PATCH net-next v2 1/3] dpll: add dpll_device op to get supported modes Ivan Vecera
2026-01-13 12:16 ` [PATCH net-next v2 2/3] dpll: add dpll_device op to set working mode Ivan Vecera
2026-01-13 17:47 ` Vadim Fedorenko [this message]
2026-01-13 18:38 ` Ivan Vecera
2026-01-13 12:16 ` [PATCH net-next v2 3/3] dpll: zl3073x: Implement device mode setting support Ivan Vecera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5a1f45f-542e-4280-a601-ae96f2d1cac4@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=Prathosh.Satish@microchip.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox