From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57742C43381 for ; Thu, 21 Mar 2019 23:10:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2DBC0218D3 for ; Thu, 21 Mar 2019 23:10:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727189AbfCUXKa convert rfc822-to-8bit (ORCPT ); Thu, 21 Mar 2019 19:10:30 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:34519 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726529AbfCUXK3 (ORCPT ); Thu, 21 Mar 2019 19:10:29 -0400 Received: by mail-wr1-f66.google.com with SMTP id p10so387068wrq.1 for ; Thu, 21 Mar 2019 16:10:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=O0kl5N/6PyhXj66K0V+CJ/x2O1BCUcTVbXfRi9zk784=; b=f4boaeAiNwvslDhovKik/y5GitPe2YO6mfUnqjp3f5kbYloZhrix6dePKNQS+gUOiM RjQ5+fzBXgz0aQn4JgDOkAEIvku0cvyMrSbsDRQQBGsz8mku3xiXQZa4knSoF28ZFWA7 ChQrnX9I+3zzbY7cYP5vaNgMP7ZKCKIyVtGMezs40RP1Fwgw6JEWHQh7Z/IzfJDP5sdv DUxCbULm0IgxwH/yz08uqbOhPCsE0xQLxOAO3MCSJ+cxgF1qvz5uzDglDjo+xT3/TOiN sZZ1KuseIZBItoFav/LCbzD1TQpdm9QMUHOczHOwQi22cEjtIYILQ8zuOacqMc/k9mXa CSlg== X-Gm-Message-State: APjAAAWU9b2XYgDyrcIcPnxxaOX9odY5g5wKsI1tIT6/aRTV4IEtbzbE v6eyZBpEctbB0zUfQwY9im8= X-Google-Smtp-Source: APXvYqy+YJyAIEjV8ama6LczDH9ghMRqor/1qdUIwYp9/vRb/ZHQJmzVp3qImnXgw9RJmz1nVYvARA== X-Received: by 2002:a05:6000:1152:: with SMTP id d18mr4315842wrx.32.1553209827875; Thu, 21 Mar 2019 16:10:27 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:b00c:66c8:99df:336]) by smtp.gmail.com with ESMTPSA id y192sm19032819wmc.6.2019.03.21.16.10.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 16:10:27 -0700 (PDT) Message-ID: Subject: Re: [PATCH bpf-next v6] tools/bpf: generate pkg-config file for libbpf From: Luca Boccassi To: Alexei Starovoitov Cc: netdev@vger.kernel.org, daniel@iogearbox.net Date: Thu, 21 Mar 2019 23:10:26 +0000 In-Reply-To: <20190321224314.m6tq4b55t6mjh2se@ast-mbp.dhcp.thefacebook.com> References: <20190319210639.6282-1-bluca@debian.org> <20190321223317.29584-1-luca.boccassi@gmail.com> <20190321224314.m6tq4b55t6mjh2se@ast-mbp.dhcp.thefacebook.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 2019-03-21 at 15:43 -0700, Alexei Starovoitov wrote: > On Thu, Mar 21, 2019 at 10:33:17PM +0000, luca.boccassi@gmail.com > wrote: > > From: Luca Boccassi > > > > Generate a libbpf.pc file at build time so that users can rely > > on pkg-config to find the library, its CFLAGS and LDFLAGS. > > > > Signed-off-by: Luca Boccassi > > Acked-by: Andrey Ignatov > > --- > > v2: use QUIET_GEN instead of QUIET_LINK to generate pc file, > > save kernel version in its own variable instead of calling > > make inline > > v3: use LIBBPF_VERSION instead of kernel_version > > v4: use -I${prefix}/include rather than -I${prefix}/include/bpf > > in the Cflags field as requested, to keep consistency with > > how the headers are used now and to avoid a dependency from > > the pc file to the headers installation > > v5: add acked-by, add SPDX line to pc file > > v6: remove URL field, generalize Description field > > It fails to build: > make -C ../../../lib/bpf OUTPUT=/data/users/ast/bpf- > next/tools/testing/selftests/bpf/ > make[1]: Entering directory `/data/users/ast/bpf-next/tools/lib/bpf' > make[2]: *** No rule to make target `libbpf.pc', needed by > `all_cmd'. Stop. > make[1]: *** [all] Error 2 > make[1]: Leaving directory `/data/users/ast/bpf-next/tools/lib/bpf' Thanks, the $(OUTPUT) prefix was missing so the out of tree build didn't work, fixed in v7. -- Kind regards, Luca Boccassi