From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
netdev@vger.kernel.org, "David Heidelberg" <david+nfc@ixit.cz>
Cc: Simon Horman <horms@kernel.org>, Jakub Kicinski <kuba@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Ian Ray <ian.ray@gehealthcare.com>, Carl Lee <carl.lee@amd.com>,
Tomasz Unger <tomasz.unger@yahoo.pl>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] nfc: Use named initializers for struct i2c_device_id
Date: Mon, 18 May 2026 17:09:54 +0200 [thread overview]
Message-ID: <c5b5025c-1925-41cc-89ee-3c52a1192f26@kernel.org> (raw)
In-Reply-To: <20260518133311.644160-2-u.kleine-koenig@baylibre.com>
On 18/05/2026 15:33, Uwe Kleine-König (The Capable Hub) wrote:
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
>
> While touching all these arrays, unify usage of whitespace in the list
> terminator.
>
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits. The former was confirmed with x86 and arm64
> builds.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
You need to refresh your tree to next - you miss David.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
prev parent reply other threads:[~2026-05-18 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 13:33 [PATCH net-next] nfc: Use named initializers for struct i2c_device_id Uwe Kleine-König (The Capable Hub)
2026-05-18 15:09 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5b5025c-1925-41cc-89ee-3c52a1192f26@kernel.org \
--to=krzk@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=carl.lee@amd.com \
--cc=david+nfc@ixit.cz \
--cc=horms@kernel.org \
--cc=ian.ray@gehealthcare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tomasz.unger@yahoo.pl \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox