From: David Ahern <dsahern@gmail.com>
To: Nikolay Aleksandrov <razor@blackwall.org>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, roopa@nvidia.com,
Joachim Wiberg <troglobit@gmail.com>,
dsahern@gmail.com, Nikolay Aleksandrov <nikolay@nvidia.com>
Subject: Re: [PATCH iproute2-next 01/17] ip: bridge: add support for mcast_vlan_snooping
Date: Fri, 27 Aug 2021 10:01:38 -0700 [thread overview]
Message-ID: <c5dcc86b-00e2-6970-334f-9f55ddb0fa17@gmail.com> (raw)
In-Reply-To: <3594d516-288c-d84e-83ec-91c5288b452c@blackwall.org>
On 8/26/21 8:11 AM, Nikolay Aleksandrov wrote:
> On 26/08/2021 18:08, Stephen Hemminger wrote:
>> On Thu, 26 Aug 2021 16:05:17 +0300
>> Nikolay Aleksandrov <razor@blackwall.org> wrote:
>>
>>> + } else if (matches(*argv, "mcast_vlan_snooping") == 0) {
>>> + __u32 mcvl_bit = 1 << BR_BOOLOPT_MCAST_VLAN_SNOOPING;
>>
>> Using matches() is problematic. since it will change how 'mcast' is
>> handled.
>>
>> Overall, bridge command (and rest of iproute2) needs to move
>> away from matches
>>
>
> Sure, I can send a follow up if you don't mind to switch all matches calls. I used it
> to be in line with the current code.
>
existing options need to stay using matches(); new options need to use
full strcmp().
next prev parent reply other threads:[~2021-08-27 17:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 13:05 [PATCH iproute2-next 00/17] bridge: vlan: add global multicast options Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 01/17] ip: bridge: add support for mcast_vlan_snooping Nikolay Aleksandrov
2021-08-26 15:08 ` Stephen Hemminger
2021-08-26 15:11 ` Nikolay Aleksandrov
2021-08-27 17:01 ` David Ahern [this message]
2021-08-26 13:05 ` [PATCH iproute2-next 02/17] bridge: vlan: add support to show global vlan options Nikolay Aleksandrov
2021-08-27 17:10 ` David Ahern
2021-08-26 13:05 ` [PATCH iproute2-next 03/17] bridge: vlan: add support for vlan filtering when dumping options Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 04/17] bridge: vlan: add support to set global vlan options Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 05/17] bridge: vlan: add global mcast_snooping option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 06/17] bridge: vlan: add global mcast_igmp_version option Nikolay Aleksandrov
2021-08-31 9:02 ` Joachim Wiberg
2021-08-31 9:04 ` Nikolay Aleksandrov
2021-08-31 9:10 ` Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 07/17] bridge: vlan: add global mcast_mld_version option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 08/17] bridge: vlan: add global mcast_last_member_count option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 09/17] bridge: vlan: add global mcast_startup_query_count option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 10/17] bridge: vlan: add global mcast_last_member_interval option Nikolay Aleksandrov
2021-08-27 17:15 ` David Ahern
[not found] ` <DM4PR12MB5278D58FD0768A3005F95804DFC89@DM4PR12MB5278.namprd12.prod.outlook.com>
2021-08-27 18:21 ` David Ahern
2021-08-26 13:05 ` [PATCH iproute2-next 11/17] bridge: vlan: add global mcast_membership_interval option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 12/17] bridge: vlan: add global mcast_querier_interval option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 13/17] bridge: vlan: add global mcast_query_interval option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 14/17] bridge: vlan: add global mcast_query_response_interval option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 15/17] bridge: vlan: add global mcast_startup_query_interval option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 16/17] bridge: vlan: add global mcast_querier option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 17/17] bridge: vlan: add support for dumping router ports Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5dcc86b-00e2-6970-334f-9f55ddb0fa17@gmail.com \
--to=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=troglobit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).