From: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: netdev@vger.kernel.org, larysa.zaremba@intel.com,
maciej.fijalkowski@intel.com,
kalesh-anakkur.purayil@broadcom.com,
Jakub Kicinski <kuba@kernel.org>,
intel-wired-lan@lists.osuosl.org,
Igor Bagnucki <igor.bagnucki@intel.com>
Subject: Re: [PATCH iwl-net v3] ice: Add netif_device_attach/detach into PF reset flow
Date: Tue, 20 Aug 2024 12:18:07 +0200 [thread overview]
Message-ID: <c5e08b9f-9424-4863-b5f5-09d11c8a1dc7@linux.intel.com> (raw)
In-Reply-To: <ba76710b-c3e2-442a-b398-2b2a87f3642c@intel.com>
On 19.08.2024 10:47, Przemek Kitszel wrote:
> On 8/19/24 10:21, Dawid Osuchowski wrote:
>> @@ -7731,6 +7733,10 @@ static void ice_rebuild(struct ice_pf *pf, enum
>> ice_reset_req reset_type)
>> ice_rebuild_arfs(pf);
>> }
>> + struct ice_vsi *vsi = ice_get_main_vsi(pf);
>
> you should separate declaration statements from expressions by one blank
> line; we also put declarations at the very front of the scope
Will fix in next revision, thanks.
>> + if (vsi && vsi->netdev)
>> + netif_device_attach(vsi->netdev);
>> +
>> ice_update_pf_netdev_link(pf);
>> /* tell the firmware we are up */
>
prev parent reply other threads:[~2024-08-20 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 8:21 [PATCH iwl-net v3] ice: Add netif_device_attach/detach into PF reset flow Dawid Osuchowski
2024-08-19 8:47 ` Przemek Kitszel
2024-08-20 10:18 ` Dawid Osuchowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5e08b9f-9424-4863-b5f5-09d11c8a1dc7@linux.intel.com \
--to=dawid.osuchowski@linux.intel.com \
--cc=igor.bagnucki@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).