From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arend van Spriel Subject: Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer Date: Fri, 12 May 2017 10:36:56 +0200 Message-ID: References: <20170512073555.12333-1-cheerx1994@gmail.com> <87tw4qqyh1.fsf@kamboji.qca.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Franky Lin , Hante Meuleman , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Kalle Valo , Xie Qirong Return-path: In-Reply-To: <87tw4qqyh1.fsf@kamboji.qca.qualcomm.com> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 5/12/2017 10:19 AM, Kalle Valo wrote: > Xie Qirong writes: > >> The combination of init_timer and setting up the data and function field >> manually is equivalent to calling setup_timer(). This is an api >> consolidation only and improves readability. >> >> Acked-by: Arend van Spriel >> Signed-off-by: Xie Qirong >> --- >> >> setup_timer.cocci suggested the following improvement: >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:383:1-11: Use >> setup_timer function for function on line 384. >> >> Patch was compile checked with: x86_64_defconfig + CONFIG_BRCMFMAC=y + >> CONFIG_BRCMFMAC_USB=y + CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + >> CONFIG_BRCMDBG=y >> >> Kernel version: 4.11.0 (localversion-next is next-20170512) > > How is this different from the first version? > > https://patchwork.kernel.org/patch/9709467/ Hi Kalle, This is actually the third version. You are referring to the not-specifically-named "v2" here, but how are you to know ;-) This third version is the same as v1 on which I commented to put the coccinelle output in the commit message. So I would still keep v2 if nothing else changed in v3 apart from my Acked-by: tag. Regards, Arend > Always add patch version "[PATCH v2]" and a changelog. I added a section > "Frequent problems" to the wiki to mention about these common problems: > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing >