From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6E28C433F5 for ; Thu, 16 Sep 2021 14:05:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD0C561130 for ; Thu, 16 Sep 2021 14:05:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238147AbhIPOGn (ORCPT ); Thu, 16 Sep 2021 10:06:43 -0400 Received: from ssl.serverraum.org ([176.9.125.105]:49571 "EHLO ssl.serverraum.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235474AbhIPOGm (ORCPT ); Thu, 16 Sep 2021 10:06:42 -0400 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 632A722239; Thu, 16 Sep 2021 16:05:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1631801120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QRqBsNTBoOGvyLlATA7p9NzQtPWwSoU4M5S63n5fs5g=; b=e9dMoUZtP5AxsfYAHXwtuTkaaRtyJzTlewq5K6tMsyKOGmXHFVrlERd5IHGcz/zP+eJRhs czWoJPUpRpI/w1JOycb7YLPYu+IRHwfeaUGowMANPURgZrkLPdgu+NKR8HfUN5KGFzlwqJ lDO9oryOuFztjMWzjvNzNvvAql6Z8uc= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 16 Sep 2021 16:05:20 +0200 From: Michael Walle To: Vladimir Oltean Cc: "Russell King (Oracle)" , netdev@vger.kernel.org, Antoine Tenart , Heiner Kallweit , Andrew Lunn , Florian Fainelli , Ioana Ciornei , Maxim Kochetkov , Bjarni Jonasson , Steen Hegelund , UNGLinuxDriver@microchip.com, bcm-kernel-feedback-list@broadcom.com Subject: Re: [RFC PATCH v2 net-next 0/5] Let phylink manage in-band AN for the PHY In-Reply-To: <20210916135445.euovk2aelndgtvid@skbuf> References: <20210830155250.4029923-1-vladimir.oltean@nxp.com> <20210830183015.GY22278@shell.armlinux.org.uk> <20210830183623.kxtbohzy4sfdbpsl@skbuf> <20210916130908.zubzqs6i6i7kbbol@skbuf> <20210916135445.euovk2aelndgtvid@skbuf> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Am 2021-09-16 15:54, schrieb Vladimir Oltean: > On Thu, Sep 16, 2021 at 03:51:28PM +0200, Michael Walle wrote: >> Am 2021-09-16 15:09, schrieb Vladimir Oltean: >> > On Mon, Aug 30, 2021 at 09:36:23PM +0300, Vladimir Oltean wrote: >> > > On Mon, Aug 30, 2021 at 07:30:15PM +0100, Russell King (Oracle) wrote: >> > > > Can we postpone this after this merge window please, so I've got time >> > > > to properly review this. Thanks. >> > > >> > > Please review at your discretion, I've no intention to post a v3 right >> > > now, and to the best of my knowledge, RFC's are not even considered >> > > for >> > > direct inclusion in the git tree. >> > >> > Hello Russell, can you please review these patches if possible? I >> > would like to repost them soon. >> >> I planned to test this on my board with the AR8031 (and add support >> there), >> but it seems I won't find time before my vacation, unfortunately. > > Oh, but there isn't any "support" to be added I though, your conclusion > last time seemed to be that it only supported in-band autoneg ON? > I was going to add a patch to implement .validate_inband_aneg for the > at803x driver to mark that fact too, I just didn't do it in the RFC. > That should also fix the ENETC ports on the LS1028A-RDB which were > migrated to phylink while they didn't have the 'managed = > "in-band-status"' > OF property, and enable new kernels to still work with the old DT blob. > Or were you thinking of something else? No, but I won't find time to test it within the next.. uhm, 30minutes until I call it a day ;) -michael