From: Florian Fainelli <f.fainelli@gmail.com>
To: Juergen Borleis <jbe@pengutronix.de>, Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de, vivien.didelot@savoirfairelinux.com,
davem@davemloft.net
Subject: Re: [PATCH 3/4] net: dsa: LAN9303: add I2C managed mode support
Date: Thu, 6 Apr 2017 06:52:06 -0700 [thread overview]
Message-ID: <c5f2bc76-c563-d990-f5b0-79b8856d0950@gmail.com> (raw)
In-Reply-To: <201704061546.04478.jbe@pengutronix.de>
On 04/06/2017 06:46 AM, Juergen Borleis wrote:
>>> + phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_LOW>;
>>> + phy-reset-duration = <200>;
>>> +
>>> + dsa,member = <0 0>;
>>> +
>>> + ports {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + port@0 { /* RMII fixed link to master */
>>> + reg = <0>;
>>> + label = "cpu";
>>> + ethernet = <&master>;
>>> + max-speed = <100>;
>>
>> max-speed does not do anything i think, since there is no adjust_link
>> function.
Since port 0 is the CPU port, we expect to find a fixed PHY for it, so
yes, this won't do much because fixed-link already appropriately limits
the speed.
--
Florian
next prev parent reply other threads:[~2017-04-06 13:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 9:20 net: dsa: add SMSC/Microchip LAN9303 three port ethernet switch driver Juergen Borleis
2017-04-05 9:20 ` [PATCH 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Juergen Borleis
2017-04-05 17:10 ` Andrew Lunn
2017-04-06 13:36 ` Juergen Borleis
2017-04-05 9:20 ` [PATCH 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Juergen Borleis
2017-04-05 18:12 ` Andrew Lunn
2017-04-06 10:18 ` Juergen Borleis
2017-04-06 11:59 ` Andrew Lunn
2017-04-06 13:42 ` Juergen Borleis
2017-04-06 10:39 ` Juergen Borleis
2017-04-05 9:20 ` [PATCH 3/4] net: dsa: LAN9303: add I2C managed mode support Juergen Borleis
2017-04-05 18:21 ` Andrew Lunn
2017-04-06 13:46 ` Juergen Borleis
2017-04-06 13:52 ` Florian Fainelli [this message]
2017-04-05 9:20 ` [PATCH 4/4] net: dsa: LAN9303: add MDIO " Juergen Borleis
2017-04-05 19:32 ` Andrew Lunn
2017-04-06 13:53 ` Florian Fainelli
2017-04-06 14:25 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5f2bc76-c563-d990-f5b0-79b8856d0950@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jbe@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).