From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Witten Subject: [PATCH 2/3] net: inet_recvmsg(): Remove unnecessary bitwise operation Date: Fri, 08 Sep 2017 05:06:26 -0000 Message-ID: References: <45aab5effc0c424a992646a97cf2ec14-mfwitten@gmail.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI Return-path: In-Reply-To: <45aab5effc0c424a992646a97cf2ec14-mfwitten@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Date: Fri, 8 Sep 2017 00:47:49 +0000 The flag `MSG_DONTWAIT' is handled by passing an argument through the dedicated parameter `nonblock' of the function `tcp_recvmsg()'. Presumably because `MSG_DONTWAIT' is handled so explicitly, it is unset in the collection of flags that are passed to `tcp_recvmsg()'; yet, this unsetting appears to be unnecessary, and so this commit removes the bitwise operation that performs the unsetting. Signed-off-by: Michael Witten --- net/ipv4/af_inet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index e31108e5ef79..2dbed042a412 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -791,7 +791,7 @@ int inet_recvmsg(struct socket *sock, struct msghdr *msg, size_t size, sock_rps_record_flow(sk); err = sk->sk_prot->recvmsg(sk, msg, size, flags & MSG_DONTWAIT, - flags & ~MSG_DONTWAIT, &addr_len); + flags, &addr_len); if (err >= 0) msg->msg_namelen = addr_len; return err; -- 2.14.1