From: "Lendacky, Thomas" <Thomas.Lendacky@amd.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 04/17] xgbe: no need to check return value of debugfs_create functions
Date: Tue, 6 Aug 2019 16:28:06 +0000 [thread overview]
Message-ID: <c604376c-465b-a35b-501c-4a416dcbe819@amd.com> (raw)
In-Reply-To: <20190806161128.31232-5-gregkh@linuxfoundation.org>
On 8/6/19 11:11 AM, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> This cleans up a lot of unneeded code and logic around the debugfs
> files, making all of this much simpler and easier to understand.
>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c | 107 ++++++-------------
> 1 file changed, 31 insertions(+), 76 deletions(-)
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c b/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c
> index b91143947ed2..b0a6c96b6ef4 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c
> @@ -438,7 +438,6 @@ static const struct file_operations xi2c_reg_value_fops = {
>
> void xgbe_debugfs_init(struct xgbe_prv_data *pdata)
> {
> - struct dentry *pfile;
> char *buf;
>
> /* Set defaults */
> @@ -451,88 +450,48 @@ void xgbe_debugfs_init(struct xgbe_prv_data *pdata)
> return;
>
> pdata->xgbe_debugfs = debugfs_create_dir(buf, NULL);
> - if (!pdata->xgbe_debugfs) {
> - netdev_err(pdata->netdev, "debugfs_create_dir failed\n");
> - kfree(buf);
> - return;
> - }
>
> - pfile = debugfs_create_file("xgmac_register", 0600,
> - pdata->xgbe_debugfs, pdata,
> - &xgmac_reg_addr_fops);
> - if (!pfile)
> - netdev_err(pdata->netdev, "debugfs_create_file failed\n");
> + debugfs_create_file("xgmac_register", 0600, pdata->xgbe_debugfs, pdata,
> + &xgmac_reg_addr_fops);
>
> - pfile = debugfs_create_file("xgmac_register_value", 0600,
> - pdata->xgbe_debugfs, pdata,
> - &xgmac_reg_value_fops);
> - if (!pfile)
> - netdev_err(pdata->netdev, "debugfs_create_file failed\n");
> + debugfs_create_file("xgmac_register_value", 0600, pdata->xgbe_debugfs,
> + pdata, &xgmac_reg_value_fops);
>
> - pfile = debugfs_create_file("xpcs_mmd", 0600,
> - pdata->xgbe_debugfs, pdata,
> - &xpcs_mmd_fops);
> - if (!pfile)
> - netdev_err(pdata->netdev, "debugfs_create_file failed\n");
> + debugfs_create_file("xpcs_mmd", 0600, pdata->xgbe_debugfs, pdata,
> + &xpcs_mmd_fops);
>
> - pfile = debugfs_create_file("xpcs_register", 0600,
> - pdata->xgbe_debugfs, pdata,
> - &xpcs_reg_addr_fops);
> - if (!pfile)
> - netdev_err(pdata->netdev, "debugfs_create_file failed\n");
> + debugfs_create_file("xpcs_register", 0600, pdata->xgbe_debugfs, pdata,
> + &xpcs_reg_addr_fops);
>
> - pfile = debugfs_create_file("xpcs_register_value", 0600,
> - pdata->xgbe_debugfs, pdata,
> - &xpcs_reg_value_fops);
> - if (!pfile)
> - netdev_err(pdata->netdev, "debugfs_create_file failed\n");
> + debugfs_create_file("xpcs_register_value", 0600, pdata->xgbe_debugfs,
> + pdata, &xpcs_reg_value_fops);
>
> if (pdata->xprop_regs) {
> - pfile = debugfs_create_file("xprop_register", 0600,
> - pdata->xgbe_debugfs, pdata,
> - &xprop_reg_addr_fops);
> - if (!pfile)
> - netdev_err(pdata->netdev,
> - "debugfs_create_file failed\n");
> -
> - pfile = debugfs_create_file("xprop_register_value", 0600,
> - pdata->xgbe_debugfs, pdata,
> - &xprop_reg_value_fops);
> - if (!pfile)
> - netdev_err(pdata->netdev,
> - "debugfs_create_file failed\n");
> + debugfs_create_file("xprop_register", 0600, pdata->xgbe_debugfs,
> + pdata, &xprop_reg_addr_fops);
> +
> + debugfs_create_file("xprop_register_value", 0600,
> + pdata->xgbe_debugfs, pdata,
> + &xprop_reg_value_fops);
> }
>
> if (pdata->xi2c_regs) {
> - pfile = debugfs_create_file("xi2c_register", 0600,
> - pdata->xgbe_debugfs, pdata,
> - &xi2c_reg_addr_fops);
> - if (!pfile)
> - netdev_err(pdata->netdev,
> - "debugfs_create_file failed\n");
> -
> - pfile = debugfs_create_file("xi2c_register_value", 0600,
> - pdata->xgbe_debugfs, pdata,
> - &xi2c_reg_value_fops);
> - if (!pfile)
> - netdev_err(pdata->netdev,
> - "debugfs_create_file failed\n");
> + debugfs_create_file("xi2c_register", 0600, pdata->xgbe_debugfs,
> + pdata, &xi2c_reg_addr_fops);
> +
> + debugfs_create_file("xi2c_register_value", 0600,
> + pdata->xgbe_debugfs, pdata,
> + &xi2c_reg_value_fops);
> }
>
> if (pdata->vdata->an_cdr_workaround) {
> - pfile = debugfs_create_bool("an_cdr_workaround", 0600,
> - pdata->xgbe_debugfs,
> - &pdata->debugfs_an_cdr_workaround);
> - if (!pfile)
> - netdev_err(pdata->netdev,
> - "debugfs_create_bool failed\n");
> -
> - pfile = debugfs_create_bool("an_cdr_track_early", 0600,
> - pdata->xgbe_debugfs,
> - &pdata->debugfs_an_cdr_track_early);
> - if (!pfile)
> - netdev_err(pdata->netdev,
> - "debugfs_create_bool failed\n");
> + debugfs_create_bool("an_cdr_workaround", 0600,
> + pdata->xgbe_debugfs,
> + &pdata->debugfs_an_cdr_workaround);
> +
> + debugfs_create_bool("an_cdr_track_early", 0600,
> + pdata->xgbe_debugfs,
> + &pdata->debugfs_an_cdr_track_early);
> }
>
> kfree(buf);
> @@ -546,7 +505,6 @@ void xgbe_debugfs_exit(struct xgbe_prv_data *pdata)
>
> void xgbe_debugfs_rename(struct xgbe_prv_data *pdata)
> {
> - struct dentry *pfile;
> char *buf;
>
> if (!pdata->xgbe_debugfs)
> @@ -559,11 +517,8 @@ void xgbe_debugfs_rename(struct xgbe_prv_data *pdata)
> if (!strcmp(pdata->xgbe_debugfs->d_name.name, buf))
> goto out;
>
> - pfile = debugfs_rename(pdata->xgbe_debugfs->d_parent,
> - pdata->xgbe_debugfs,
> - pdata->xgbe_debugfs->d_parent, buf);
> - if (!pfile)
> - netdev_err(pdata->netdev, "debugfs_rename failed\n");
> + debugfs_rename(pdata->xgbe_debugfs->d_parent, pdata->xgbe_debugfs,
> + pdata->xgbe_debugfs->d_parent, buf);
>
> out:
> kfree(buf);
>
next prev parent reply other threads:[~2019-08-06 16:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 16:11 [PATCH 00/17] Networking driver debugfs cleanups Greg Kroah-Hartman
2019-08-06 16:11 ` [PATCH 01/17] wimax: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-08-06 16:11 ` [PATCH 02/17] bonding: no need to print a message if debugfs_create_dir() fails Greg Kroah-Hartman
2019-08-06 16:11 ` [PATCH 03/17] mlx5: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-08-06 19:41 ` Saeed Mahameed
2019-08-06 19:47 ` gregkh
2019-08-06 20:37 ` Saeed Mahameed
2019-08-06 16:11 ` [PATCH 04/17] xgbe: " Greg Kroah-Hartman
2019-08-06 16:28 ` Lendacky, Thomas [this message]
2019-08-06 16:11 ` [PATCH 05/17] bnxt: " Greg Kroah-Hartman
2019-08-06 16:11 ` [PATCH 06/17] cxgb4: " Greg Kroah-Hartman
2019-08-06 16:11 ` [PATCH 07/17] hns3: " Greg Kroah-Hartman
2019-08-06 16:11 ` [PATCH 08/17] nfp: " Greg Kroah-Hartman
2019-08-06 16:50 ` Jakub Kicinski
2019-08-06 17:00 ` Greg Kroah-Hartman
2019-08-06 17:30 ` Jakub Kicinski
2019-08-06 16:11 ` [PATCH 09/17] stmmac: " Greg Kroah-Hartman
2019-08-06 16:11 ` [PATCH 10/17] dpaa2: " Greg Kroah-Hartman
2019-08-06 16:11 ` [PATCH 11/17] qca: " Greg Kroah-Hartman
2019-08-08 6:30 ` Michael Heimpold
2019-08-06 16:11 ` [PATCH 12/17] skge: " Greg Kroah-Hartman
2019-08-06 17:44 ` Stephen Hemminger
2019-08-06 16:11 ` [PATCH 13/17] mvpp2: " Greg Kroah-Hartman
2019-08-06 16:11 ` [PATCH 14/17] fm10k: " Greg Kroah-Hartman
2019-08-06 16:11 ` [PATCH 15/17] i40e: " Greg Kroah-Hartman
2019-08-06 16:11 ` [PATCH 16/17] ixgbe: " Greg Kroah-Hartman
2019-08-06 16:11 ` [PATCH 17/17] ieee802154: " Greg Kroah-Hartman
2019-08-06 19:22 ` Stefan Schmidt
2019-08-06 19:48 ` Greg Kroah-Hartman
2019-08-09 1:37 ` [PATCH 00/17] Networking driver debugfs cleanups David Miller
2019-08-09 1:42 ` David Miller
2019-08-09 12:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c604376c-465b-a35b-501c-4a416dcbe819@amd.com \
--to=thomas.lendacky@amd.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).