Re: [PATCH net] net: hibmcge: fix incorrect packets in the RX path issue

[Jijie Shao <shaojijie@huawei.com>]

on 2026/5/15 8:16, Jakub Kicinski wrote:
> On Tue, 12 May 2026 20:34:56 +0800 Jijie Shao wrote:
>> Therefore, this patch disables the Relaxed Ordering to ensure the
>> strict order of packets and descriptors.
>>
>> Additionally, during the process of analyzing the issue,
>> it was discovered that the position of dma_rmb() was incorrect.
>> It should first execute dma_sync_single_for_cpu(), and then dma_rmb().
>> This patch has also made the corresponding modifications.
> Should be a separate patch.

ok

>
>> Fixes: f72e25594061 ("net: hibmcge: Implement rx_poll function to receive packets")
>> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
>> ---
>>   drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c | 4 +++-
>>   drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c | 6 +++---
>>   2 files changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c b/drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c
>> index 068da2fd1fea..5b91b596349c 100644
>> --- a/drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c
>> +++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c
>> @@ -420,6 +420,8 @@ static int hbg_pci_init(struct pci_dev *pdev)
>>   		return -ENOMEM;
>>   
>>   	pci_set_master(pdev);
>> +	pcie_capability_clear_word(pdev, PCI_EXP_DEVCTL,
>> +				   PCI_EXP_DEVCTL_RELAX_EN);
>>   	return 0;
>>   }
>>   
>> @@ -525,4 +527,4 @@ module_exit(hbg_module_exit);
>>   MODULE_LICENSE("GPL");
>>   MODULE_AUTHOR("Huawei Tech. Co., Ltd.");
>>   MODULE_DESCRIPTION("hibmcge driver");
>> -MODULE_VERSION("1.0");
>> +MODULE_VERSION("2.0");
> Please don't change MODULE_VERSIONs they are meaningless for in-tree
> modules.

Our users typically compile the driver as a separate ko (CONFIG_HIBMCGE=M).
I want to use the version to quickly determine whether the user's driver code has this patch.

Thanks,
Jijie Shao