From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next 0/7] net: Support Wake-on-LAN using filters Date: Tue, 17 Jul 2018 09:28:52 -0700 Message-ID: References: <20180717153645.7500-1-f.fainelli@gmail.com> <20180717154702.GD968@lunn.ch> <7e48b9b3-3e90-e56e-46af-b1108dc63292@gmail.com> <20180717162136.GH968@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linville@tuxdriver.com, davem@davemloft.net, vivien.didelot@savoirfairelinux.com To: Andrew Lunn Return-path: Received: from mail-qt0-f180.google.com ([209.85.216.180]:44964 "EHLO mail-qt0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729508AbeGQRCY (ORCPT ); Tue, 17 Jul 2018 13:02:24 -0400 Received: by mail-qt0-f180.google.com with SMTP id b15-v6so1404310qtp.11 for ; Tue, 17 Jul 2018 09:28:57 -0700 (PDT) In-Reply-To: <20180717162136.GH968@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 07/17/2018 09:21 AM, Andrew Lunn wrote: >>>> ethtool -s gphy wol f filters 0x2 >>> >>> What does this 0x2 represent? >> >> 0x2 = bit 1 is set, which corresponds to the filter ID that was returned >> from the previous ethtool::rxnfc command invocation. If ethtool >> --config-nfc returned 3, then we would have used filters 0x8, etc. > > It would be a simpler for the user if you could pass the filter IDs as > a list, and let ethtool do the shift and OR. Sure, I can definitively add that, is a comma separator okay with you for that? E.g: ethtool -s gphy wol f filters 0,1,2,3,4,5,6,7 -- Florian