public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Edward Cree <ecree@solarflare.com>
To: Vladimir Oltean <olteanv@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>, netdev <netdev@vger.kernel.org>
Subject: Re: Correct tc-vlan usage
Date: Wed, 15 Apr 2020 19:13:36 +0100	[thread overview]
Message-ID: <c658ea46-7d67-3218-f565-9b9c1a6b4ee2@solarflare.com> (raw)
In-Reply-To: <CA+h21hoxwRdhq4y+w8Kwgm74d4cA0xLeiHTrmT-VpSaM7obhkg@mail.gmail.com>

On 15/04/2020 18:59, Vladimir Oltean wrote:
> My problem is that the VLAN tags are discarded by the network
> interface's RX filter:
>
> # ethtool -S eno2
>      SI VLAN nomatch u-cast discards: 1280
>
> and this is because nobody calls .ndo_vlan_rx_add_vid for these VLANs
> (only the 8021q driver does).
You could try creating the VLAN interfaces anyway; no traffic will hit
 them, because the tc rule popped the VLAN, but they'll call the ndo.
Idk if that'll actually work though... and it'd still be possible to
 TX through the VLAN devices, which you don't want.

-ed

  reply	other threads:[~2020-04-15 18:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15 17:59 Correct tc-vlan usage Vladimir Oltean
2020-04-15 18:13 ` Edward Cree [this message]
2020-04-15 18:14   ` Vladimir Oltean
2020-04-20 14:37 ` Jiri Pirko
2020-04-21 18:26   ` Vladimir Oltean
2020-04-21 19:51     ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c658ea46-7d67-3218-f565-9b9c1a6b4ee2@solarflare.com \
    --to=ecree@solarflare.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox