From: Martin Weinelt <martin@linuxlounge.net>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
bridge@lists.linux-foundation.org,
Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: Use-after-free in br_multicast_rcv
Date: Tue, 2 Jul 2019 10:46:22 +0200 [thread overview]
Message-ID: <c66cd547-6cbe-40bf-e42c-d307956644fa@linuxlounge.net> (raw)
In-Reply-To: <6dc6e89b-8b40-7dac-ec69-f4223d5dc147@cumulusnetworks.com>
Hi Nik,
On 7/2/19 12:37 AM, Nikolay Aleksandrov wrote:
> On 7/2/19 1:17 AM, Martin Weinelt wrote:
>> Hi again,
>>
>> On 7/1/19 7:37 PM, Nikolay Aleksandrov wrote:
>>> I see, thanks for clarifying this. So on the KASAN could you please try the attached patch ?
>>> Also could you please run the br_multicast_rcv+xxx addresses through
>>> linux/scripts/faddr2line for your kernel/bridge:
>>> usage: faddr2line [--list] <object file> <func+offset> <func+offset>...
>>>
>>> Thanks,
>>> Nik
>>>
>>
>> back with a new report. This is 5.2.0-rc7 + your patch.
>>
>> Best,
>> Martin
>>
>
> Thanks! Aaargh.. I made a stupid mistake hurrying to send the patch, apologies.
> Here's the fixed version, please give it a go. This report is because
> of my change, not because of the previous bug that should've been fixed.
>
I applied your latest patch against 5.2.0-rc7 and it seems to have fixed the issue as,
after 6 hours of uptime, the KASAN report isn't coming up anymore.
Also there are currently no kmemleak results coming up on 5.2.0-rc7, so I'll be
looking at the v4.19.x series next.
Thank you!
Best
Martin
next prev parent reply other threads:[~2019-07-02 8:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <41ac3aa3-cbf7-1b7b-d847-1fb308334931@linuxlounge.net>
[not found] ` <E0170D52-C181-4F0F-B5F8-F1801C2A8F5A@cumulusnetworks.com>
2019-06-29 13:23 ` Use-after-free in br_multicast_rcv Martin Weinelt
2019-07-01 16:53 ` Martin Weinelt
2019-07-01 17:03 ` Nikolay Aleksandrov
2019-07-01 17:31 ` Martin Weinelt
2019-07-01 17:37 ` Nikolay Aleksandrov
2019-07-01 22:17 ` Martin Weinelt
2019-07-01 22:37 ` Nikolay Aleksandrov
2019-07-02 8:46 ` Martin Weinelt [this message]
2019-07-02 3:33 ` [PATCH TEST] net: bridge: mcast: fix possible uses of stale pointers kbuild test robot
2019-07-02 3:33 ` [PATCH] fix noderef.cocci warnings kbuild test robot
2019-07-23 22:54 ` [PATCH TEST] net: bridge: mcast: fix possible uses of stale pointers kbuild test robot
2019-07-23 22:54 ` [PATCH] fix noderef.cocci warnings kbuild test robot
2019-07-23 23:21 ` Nikolay Aleksandrov
2019-08-08 15:10 ` [PATCH TEST] net: bridge: mcast: fix possible uses of stale pointers kbuild test robot
2019-08-08 15:10 ` [PATCH] fix noderef.cocci warnings kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c66cd547-6cbe-40bf-e42c-d307956644fa@linuxlounge.net \
--to=martin@linuxlounge.net \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).