From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: [PATCH net] sctp: fix rcu usage on proc listing Date: Tue, 19 Jan 2016 19:59:03 -0200 Message-ID: Cc: Vlad Yasevich , Neil Horman , Xin Long To: netdev@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54059 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753736AbcASV7P (ORCPT ); Tue, 19 Jan 2016 16:59:15 -0500 Sender: netdev-owner@vger.kernel.org List-ID: From: Marcelo Ricardo Leitner commit 39f66a7dce32 ("sctp: apply rhashtable api to sctp procfs") removed a rcu_read_lock() too much at sctp_remaddr_seq_show(). Fixes: 39f66a7dce32 ("sctp: apply rhashtable api to sctp procfs") Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/proc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/sctp/proc.c b/net/sctp/proc.c index dfa7eeccb5373053f460f1026a58e4a2ba015a69..4fdf4387910696492ba568b1096dd12e8e7221e2 100644 --- a/net/sctp/proc.c +++ b/net/sctp/proc.c @@ -491,6 +491,7 @@ static int sctp_remaddr_seq_show(struct seq_file *seq, void *v) tsp = (struct sctp_transport *)v; assoc = tsp->asoc; + rcu_read_lock(); list_for_each_entry_rcu(tsp, &assoc->peer.transport_addr_list, transports) { if (tsp->dead) @@ -543,6 +544,7 @@ static int sctp_remaddr_seq_show(struct seq_file *seq, void *v) seq_printf(seq, "\n"); } + rcu_read_unlock(); return 0; } -- 2.5.0