From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B61A23E5592 for ; Fri, 15 May 2026 07:22:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778829771; cv=none; b=IK2uFPue1/YFkX06WyeYgl8A5t2p3R3A0acnJer9gfqSr+21gXBoQGYecpUs2/m9iF9m/A/2fNqE5NlcbRbpG1WNw89brXJaZAd8HGpvcvC4/osXd0LqEFAGl6cP/DNqxLFqfqIIniqvEVU9VjduMSmVjt+l2PZ1rbUFv2Jb+gc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778829771; c=relaxed/simple; bh=M5vd016TcRdRSUv4seola20l4iNFnPrQGzS8Z2y9bNU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dw/jcJ73azoyzAuHet942ZvEGHonosWp/7xh2M1vW8lnmbVMh+qKmkUBdojvhC8Tp6MUVYGLCft8BYDZNK15j7MZvOY2eNp/jJF4eqtArxybY0wyfkduTxFluJQYbb72Yhr073XK2SxawbpXYqhrA8ocAdj6I2UKB1MWiWK/XvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Bp6a4v2C; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Bp6a4v2C" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id CADF51A35DE; Fri, 15 May 2026 07:22:45 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 8B829606FD; Fri, 15 May 2026 07:22:45 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id DE0F011AF8528; Fri, 15 May 2026 09:22:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1778829760; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=LiYd4Q77TJoxE4Lg0VNL4iDlwSTHKmAt01MSoUIgW7w=; b=Bp6a4v2CJypag5hsee3IozT6CUlV2Ym0MEo+vW6q/ELA/EtUo9tYsIr8BgkdEX2Q1ft0B9 1VFXHoPADNqqMcmpDVx0400w9cjB73eZBdUOLrxC4o64S6X40RJzkT3aYNdvIYe+63YXuW nxEptrspMNCAM1Z4idDoiBaCdk107BiztgStMa4+o8oByxsHGpy776Oyds5fynBqhfFjtO kfrdB7TCRgu28vo4L9nvNeZRXpRlnCwD9tWocZId0mfJa1pE4vkh8QBRxo8v4XqRfyHU33 2Dzah9zmBxROsIVR7psn1a1DiyAAryYvdB5pP6fBsqhuSBwDTEM5PD1vxvxWjg== Message-ID: Date: Fri, 15 May 2026 09:22:29 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v10 6/9] net: phy: phy_port: Store information about a MII port's vacant state To: Andrew Lunn Cc: davem@davemloft.net, Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , Heiner Kallweit , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?UTF-8?Q?K=C3=B6ry_Maincent?= , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Oleksij Rempel , =?UTF-8?Q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Romain Gantois , Daniel Golle , Dimitri Fedrau , Frank Wunderlich References: <20260513130521.1064094-1-maxime.chevallier@bootlin.com> <20260513130521.1064094-7-maxime.chevallier@bootlin.com> <97cd33a0-ee74-4f64-b11a-bb5b88bce79a@lunn.ch> Content-Language: en-US From: Maxime Chevallier In-Reply-To: <97cd33a0-ee74-4f64-b11a-bb5b88bce79a@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Andrew, On 5/14/26 15:58, Andrew Lunn wrote: >> We have information about what MII they can handle, however we don't >> store anything about whether they are currently connected to an SFP >> module or not. As phy_port aims at listing the front-facing ports, let's >> store an "vacant" bit to know whether or not a MII port is currently >> vacant (i.e. there's no module in the SFP cage), or not (i.e. >> there's an SFP module). > > vacant == False actually means a bit more than there is a module in > the cage. It also means that, so far, we have not had any errors > trying to use the module. If there is an error, we might have a module > physically in the cage, but vacant == True. This is a good point. Even with an error, we should have vacant = false. TBH I'm unsure how to name this, vacant may not be the best word there, but I'm struggling to find a better term. maybe "empty" ? > We should be careful with the wording, both in the commit message, and > here: > >> + * @vacant: For MII ports, indicates whether or not the port has a connection to >> + * another device (e.g. for SFP ports, indicates the absence or presence >> + * of an SFP module) >> */ I'll reword this along with the netlink doc. Thank you very very much for the reviews, Maxime > > Andrew