From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 253BDC43381 for ; Sun, 31 Mar 2019 13:19:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD34220830 for ; Sun, 31 Mar 2019 13:19:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FVrY/XPy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731118AbfCaNTF (ORCPT ); Sun, 31 Mar 2019 09:19:05 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:33931 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726863AbfCaNTE (ORCPT ); Sun, 31 Mar 2019 09:19:04 -0400 Received: by mail-wr1-f67.google.com with SMTP id p10so8384645wrq.1 for ; Sun, 31 Mar 2019 06:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=OTolZab9lJ3fgignr7Mlh50+proVK1JWUlpfA78Dh74=; b=FVrY/XPyny6agyYBwYobcTWO3EDOu+ASN1IOmt97mPalqo52yP4g70ncDRXU9nNppV gSoPl1dsKATStnrku0CL9YhDf6nzCkYnz/blbv5dGvEyP9xjX/HzlRrOkCXiwCoEJuZj 62x6Tcv2AEHH1dXxCHXHlc+uouJx3Ij1cHLKV9cqcLAdoAnViQWgUGcN0ar5POjUir4s CLdwcgj6zp3ExuypoFZVMgApAOisQzn63WnWZQ6/iHFeBDlrlBOO6xMB3FWpiO8q7EXG HpCQOu3JQuaETl+MA4C41YMcdtPATd0OEDK1CB4VcE7MswD1pKg1JViBsqAqm1lLZ5kz bbfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=OTolZab9lJ3fgignr7Mlh50+proVK1JWUlpfA78Dh74=; b=CP3axdDRB73KAsTaBTy9waeuJbbxnt97mVd7S76mTkIRZ8quIa4s3HX9+aXpT+okYY evZyRVN20uKrZRwd1ZoNRe4pNvCVuMyMIhgjGB7KHdwXwQ3G3RUOljqmy1nLG1mR+D+k S3HkVASwll85pw90BVVycTbMYwQN2e3jX7dvQ07ttTvUx++YF7YwsIRbYU8pIqaRg22R 1K9z6JWDlj7xcRy/U3sy5ecD7pOhv2DANhbAigs5oOLa1dSk5iG4Z+yLsIJ3I1s2AcF2 Mx78Sv2HzJSMtlwd3FbJsaIhVlBQiLSs5YIMdI0tn2OjXDwGZXgAf9dhhgbgFApg7Tx+ oZfg== X-Gm-Message-State: APjAAAUHOqjEJx10kwDft1evULtEu5jD8yeUHRg+c8Utl1fz4Mz7UjoE YECBS7EwDtFPVgxZHX84HnBhAZKG X-Google-Smtp-Source: APXvYqyAX4iS9sXOlNtkcnV5wVZjAyYL31LkgsIwCHEyrTCISMIZMVXODh4ejCG54+oXWIebLmZgAA== X-Received: by 2002:adf:dd8c:: with SMTP id x12mr39318564wrl.262.1554038342837; Sun, 31 Mar 2019 06:19:02 -0700 (PDT) Received: from ?IPv6:2003:ea:8be1:dd00:a4e7:3af3:db88:50bb? (p200300EA8BE1DD00A4E73AF3DB8850BB.dip0.t-ipconnect.de. [2003:ea:8be1:dd00:a4e7:3af3:db88:50bb]) by smtp.googlemail.com with ESMTPSA id z74sm29691139wmc.2.2019.03.31.06.19.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Mar 2019 06:19:01 -0700 (PDT) To: Realtek linux nic maintainers , David Miller Cc: "netdev@vger.kernel.org" , Jesper Dangaard Brouer , Edward Cree From: Heiner Kallweit Subject: [PATCH net-next] r8169: use netif_receive_skb_list batching Message-ID: Date: Sun, 31 Mar 2019 15:18:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use netif_receive_skb_list() instead of napi_gro_receive() to benefit from batched skb processing. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index a8ca26c2a..c9ee1c8eb 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -6426,6 +6426,7 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget { unsigned int cur_rx, rx_left; unsigned int count; + LIST_HEAD(rx_list); cur_rx = tp->cur_rx; @@ -6501,7 +6502,7 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget if (skb->pkt_type == PACKET_MULTICAST) dev->stats.multicast++; - napi_gro_receive(&tp->napi, skb); + list_add_tail(&skb->list, &rx_list); u64_stats_update_begin(&tp->rx_stats.syncp); tp->rx_stats.packets++; @@ -6516,6 +6517,8 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget count = cur_rx - tp->cur_rx; tp->cur_rx = cur_rx; + netif_receive_skb_list(&rx_list); + return count; } -- 2.21.0