From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18480C282C0 for ; Fri, 25 Jan 2019 16:30:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3FFA218B0 for ; Fri, 25 Jan 2019 16:30:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726451AbfAYQaz (ORCPT ); Fri, 25 Jan 2019 11:30:55 -0500 Received: from simcoe208srvr.owm.bell.net ([184.150.200.208]:48252 "EHLO torfep02.bell.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726122AbfAYQaz (ORCPT ); Fri, 25 Jan 2019 11:30:55 -0500 Received: from bell.net torfep02 184.150.200.158 by torfep02.bell.net with ESMTP id <20190125163054.UPLS12500.torfep02.bell.net@torspm02.bell.net> for ; Fri, 25 Jan 2019 11:30:54 -0500 Received: from [192.168.0.138] (really [64.231.92.241]) by torspm02.bell.net with ESMTP id <20190125163054.WVKE19016.torspm02.bell.net@[192.168.0.138]>; Fri, 25 Jan 2019 11:30:54 -0500 To: Andrew Lunn Cc: Russell King , Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org References: <49eec816-9238-c893-0860-602aa8965515@bell.net> <20190122202834.GB12052@lunn.ch> <09fce2e0-9dd2-ea30-7e7d-72f04eede68b@bell.net> <20190122223649.GD3634@lunn.ch> <20190123002240.GF3634@lunn.ch> From: John David Anglin Openpgp: preference=signencrypt Subject: Re: net: phylink: dsa: mv88e6xxx: flaky link detection on switch ports with internal PHYs Message-ID: Date: Fri, 25 Jan 2019 11:30:54 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190123002240.GF3634@lunn.ch> Content-Type: multipart/mixed; boundary="------------6C25D4F831B8FB4EA2C92DD7" Content-Language: en-US X-Cloudmark-Analysis: v=2.2 cv=IPLtMknG c=1 sm=0 tr=0 a=jJmVOGxBrKxWvcjqaG+oVg==:17 a=3JhidrIBZZsA:10 a=r77TgQKjGQsHNAKrUKIA:9 a=FBHGMhGWAAAA:8 a=DPWytXmZ2azKmLd7wcQA:9 a=QEXdDO2ut3YA:10 a=TxiMZfdOlwOkPqgT9tgA:9 a=l6ZAJouCkPoA:10 a=9gvnlMMaQFpL9xblJ6ne:22 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This is a multi-part message in MIME format. --------------6C25D4F831B8FB4EA2C92DD7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2019-01-22 7:22 p.m., Andrew Lunn wrote: > >From my Espressobin > > cat /proc/interrupts > ... > 44: 0 0 mv88e6xxx-g1 3 Edge mv88e6xxx-g1-atu= -prob > 46: 0 0 mv88e6xxx-g1 5 Edge mv88e6xxx-g1-vtu= -prob > 48: 38 24 mv88e6xxx-g1 7 Edge mv88e6xxx-g2 > 51: 0 1 mv88e6xxx-g2 1 Edge !soc!internal-re= gs@d0000000!mdio@32004!switch0@1!mdio:11 > 52: 0 0 mv88e6xxx-g2 2 Edge !soc!internal-re= gs@d0000000!mdio@32004!switch0@1!mdio:12 > 53: 38 23 mv88e6xxx-g2 3 Edge !soc!internal-re= gs@d0000000!mdio@32004!switch0@1!mdio:13 > > These are PHY interrupts. > Thanks.=C2=A0 That was the clue.=C2=A0 I had tried to enable hardware for= support for switch interrupts.=C2=A0 However, the espressobin connects the switch interrupt output to a southbridge pin that only supports edge interrupts. Link detection works okay once the attached change is removed.=C2=A0 I ma= y try and see if moving the interrupt to a northbridge pin works. I have to wonder about the use of edge interrupts.=C2=A0 Given that a GPI= O interrupt isn't defined for the mv88e6xxx, then the interrupt must be done by polling the global1 control register. This also makes me wonder about this SD interrupt: 43:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0=C2=A0=C2=A0=C2=A0=C2=A0 GPIO1=C2= =A0=C2=A0 3 Edge=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 d00d0000.sdhci cd Many poeple have trouble with SD cards on reboot. Although the driver doesn't handle AVB interrupts, I started down this path to try get ptp4l working better.=C2=A0 I have tweaked the polling but there are still circumstances where timestamps are overwritten (or not written). Dave --=20 John David Anglin dave.anglin@bell.net --------------6C25D4F831B8FB4EA2C92DD7 Content-Type: text/plain; charset=UTF-8; name="armada-3720-espressobin.dts-2.d" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="armada-3720-espressobin.dts-2.d" ZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvbWFydmVsbC9hcm1hZGEtMzcyMC1l c3ByZXNzb2Jpbi5kdHMgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZlbGwvYXJtYWRhLTM3 MjAtZXNwcmVzc29iaW4uZHRzDQppbmRleCAzYWIyNWFkNDAyYjkuLjY1YTNmZjRkYTYxMCAx MDA2NDQNCi0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvbWFydmVsbC9hcm1hZGEtMzcyMC1l c3ByZXNzb2Jpbi5kdHMNCisrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvbWFydmVsbC9hcm1h ZGEtMzcyMC1lc3ByZXNzb2Jpbi5kdHMNCkBAIC0xMjYsNiArMTI2LDE0IEBADQogDQogCQlk c2EsbWVtYmVyID0gPDAgMD47DQogDQorCQlpbnRlcnJ1cHQtcGFyZW50ID0gPCZncGlvc2I+ Ow0KKwkJLyogQWN0dWFsbHksIHRoZSBpcnEgaXMgYWN0aXZlIGxvdyBidXQgZ3Bpb3NiIGRv ZXNuJ3QNCisJCSAgIHN1cHBvcnQgdGhhdC4gIEZhbGxpbmcgZWRnZSBzZWVtcyB0byB3b3Jr IG9rYXkuDQorCQkgICBXZSBuZWVkIHRoaXMgZm9yIHB0cCBzdXBwb3J0ICovDQorCQlpbnRl cnJ1cHRzID0gPDIzIElSUV9UWVBFX0VER0VfRkFMTElORz47DQorCQlpbnRlcnJ1cHQtY29u dHJvbGxlcjsNCisJCSNpbnRlcnJ1cHQtY2VsbHMgPSA8Mj47DQorDQogCQlwb3J0cyB7DQog CQkJI2FkZHJlc3MtY2VsbHMgPSA8MT47DQogCQkJI3NpemUtY2VsbHMgPSA8MD47DQo= --------------6C25D4F831B8FB4EA2C92DD7--