From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F51C43381 for ; Thu, 21 Feb 2019 15:23:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B49B2083B for ; Thu, 21 Feb 2019 15:23:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sdnBoZBE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728303AbfBUPXF (ORCPT ); Thu, 21 Feb 2019 10:23:05 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:41849 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbfBUPXE (ORCPT ); Thu, 21 Feb 2019 10:23:04 -0500 Received: by mail-pl1-f194.google.com with SMTP id y5so8763902plk.8; Thu, 21 Feb 2019 07:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=e+zcudNKINzmQRoMjENIErv2Krr0ONiNaHniwcy+i44=; b=sdnBoZBEuBnRizNgb6wmoJiyvJd3TLk6+MQ+lJBvGWMk5uUTmtSl1smQlUmmuTpe34 NW2E6BhagKYctZsUHDEfDCKmcI/gJpkMu0F00ntrOHc8FlTBwYxCXISf1E8WV7n4E9cp 4ParNolHa9hBm5GkWpyzjW8g+k6WwQDQV7HBpDaxi8zD6NkjpGs4Ftd0Z4KcUGqm89aB vqNTuOv2GKO5J0cbNcU7zseQP6ifO9JxPYL/62TkAusavhCd4zJvKzQ2Kb4OKMX0igf6 XQm7AjW8IgowKvBE69diPfcYuAv5Ebkn12i56IwJL4G1geWYFGae4OdFqHMmwXuzvgrk PdRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e+zcudNKINzmQRoMjENIErv2Krr0ONiNaHniwcy+i44=; b=qOOoNHMuhnevj67mlED65CGj45S8Qy6wwOgDO7zRBxpdd+zukW6rcDjJsqJ0sGltyE UTJzJqwbb1Hu64nOK0dqzFF8ymLxQlOfcVgXU61cNKtPZamiNp1NxqE5I+lL/zs6Xm/s FuFRUlNxLsXrZMsjVvNbHFMfhtnmgqbkagCH+N3Ou3fOv66foDvnCgoMvnsgjGvLoFc6 g9GvBTrk2bs+Oa1FfdF71bE1XSd9ek4B/RaxYhEcSmhNNZk6gp6fCizCF+7KSrzQXj9t L9j+pEn8pBfMMFd2cWA9HvqSRb/P5XgYt9zW1RCKIL5s71ciPBqjgoj/3VqINApXnUeA iEzg== X-Gm-Message-State: AHQUAuayxbmLQfx9bLIlfuh1XozhNTYoXJDkN8Rr+vfLjA7KPupH8bQj 8yKHd9x846BR+w5TtlWYMdY= X-Google-Smtp-Source: AHgI3IZXIKlW3Tp1q2ofqRSfKUUT9BifA3ig6MpFQz2o7ZVc3bi0cFihl2R60JcG/HUpypXAXSdz6g== X-Received: by 2002:a17:902:8203:: with SMTP id x3mr17156999pln.159.1550762584081; Thu, 21 Feb 2019 07:23:04 -0800 (PST) Received: from [172.27.227.247] ([216.129.126.118]) by smtp.googlemail.com with ESMTPSA id t5sm35868725pfb.60.2019.02.21.07.23.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Feb 2019 07:23:03 -0800 (PST) Subject: Re: [PATCH iproute2-next v1 02/19] rdma: Remove duplicated print code To: Leon Romanovsky Cc: Leon Romanovsky , netdev , RDMA mailing list , Stephen Hemminger References: <20190220072136.3840-1-leon@kernel.org> <20190220072136.3840-3-leon@kernel.org> From: David Ahern Message-ID: Date: Thu, 21 Feb 2019 10:23:01 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190220072136.3840-3-leon@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/20/19 2:21 AM, Leon Romanovsky wrote: > From: Leon Romanovsky > > There is no need to keep same print functions for > uint32_t and uint64_t, unify them into one function. > > Signed-off-by: Leon Romanovsky > --- > rdma/res.c | 22 +++++++--------------- > 1 file changed, 7 insertions(+), 15 deletions(-) > > diff --git a/rdma/res.c b/rdma/res.c > index 6b0f5fe3..87865ec8 100644 > --- a/rdma/res.c > +++ b/rdma/res.c > @@ -808,28 +808,20 @@ static int res_cq_parse_cb(const struct nlmsghdr *nlh, void *data) > return MNL_CB_OK; > } > > -static void print_key(struct rd *rd, const char *name, uint32_t val) > +static void print_key(struct rd *rd, const char *name, uint64_t val) > { > if (rd->json_output) > jsonw_xint_field(rd->jw, name, val); > else > - pr_out("%s 0x%x ", name, val); > + pr_out("%s 0x%" PRIx64 " ", name, val); > } what's the plan to move rdma tool to iproute2's json functions? I realize rdma tool inherited this from devlink, but this command does not need to continue managing this.