From: David Ahern <dsa@cumulusnetworks.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Martin KaFai Lau <kafai@fb.com>,
Andrey Konovalov <andreyknvl@google.com>
Subject: Re: [PATCH net] net: ipv6: RTF_PCPU should not be settable from userspace
Date: Thu, 20 Apr 2017 16:43:03 -0600 [thread overview]
Message-ID: <c6f4f382-26ac-6679-adba-605e8f29cf6a@cumulusnetworks.com> (raw)
In-Reply-To: <CAM_iQpUbuzie86Cf96Q9F53UiamJixr-aVkAKtgvZFtiKPngUw@mail.gmail.com>
On 4/20/17 4:39 PM, Cong Wang wrote:
> On Wed, Apr 19, 2017 at 2:19 PM, David Ahern <dsa@cumulusnetworks.com> wrote:
>>
>> Fix by checking for the flag and failing with EINVAL.
>>
>
> I am still not sure about this. There are a few unused bits in
> this flag, we simply ignore the rest, right? Why should we
> reject this one instead of all of those we don't use?
>
RTF_PCPU most definitely should not be set by userspace. arguably it
should not be returned to userspace either, but it is part of the uapi.
I scanned the others. It is not clear that others should fail with
EINVAL. Certainly a mask of unused flags can be added, but to me that is
on top of this bug fix.
next prev parent reply other threads:[~2017-04-20 22:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 21:19 [PATCH net] net: ipv6: RTF_PCPU should not be settable from userspace David Ahern
2017-04-19 21:52 ` Martin KaFai Lau
2017-04-20 12:09 ` Andrey Konovalov
2017-04-20 22:39 ` Cong Wang
2017-04-20 22:43 ` David Ahern [this message]
2017-04-20 23:37 ` Cong Wang
2017-04-21 0:16 ` Martin KaFai Lau
2017-04-20 23:38 ` Martin KaFai Lau
2017-04-21 17:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6f4f382-26ac-6679-adba-605e8f29cf6a@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=andreyknvl@google.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox