From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Brahmajit Das <listout@listout.xyz>
Cc: andrew+netdev@lunn.ch, anthony.l.nguyen@intel.com,
davem@davemloft.net, intel-wired-lan@lists.osuosl.org,
kuba@kernel.org, netdev@vger.kernel.org,
przemyslaw.kitszel@intel.com
Subject: Re: [PATCH v2] net: intel: fm10k: Fix parameter idx set but not used
Date: Tue, 2 Sep 2025 11:34:00 +0100 [thread overview]
Message-ID: <c7005c02-63dc-4316-905c-e02283e398c5@linux.dev> (raw)
In-Reply-To: <20250902072422.603237-1-listout@listout.xyz>
On 02/09/2025 08:24, Brahmajit Das wrote:
> Variable idx is set in the loop, but is never used resulting in dead
> code. Building with GCC 16, which enables
> -Werror=unused-but-set-parameter= by default results in build error.
> This patch removes the idx parameter, since all the callers of the
> fm10k_unbind_hw_stats_q as 0 as idx anyways.
>
> Suggested-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
> Signed-off-by: Brahmajit Das <listout@listout.xyz>
> ---
> changes in v2:
> - Removed the idx parameter, since all callers of
> fm10k_unbind_hw_stats_q passes idx as 0 anyways.
Just a reminder that you shouldn't send another version of the patch
as a reply to the previous version. And you have to wait for at least
24h before sending next version to let other reviewers look at the code.
Current submission looks OK in patchwork, so no action is needed from
you right now.
Thanks,
Vadim
next prev parent reply other threads:[~2025-09-02 10:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 21:31 [PATCH] net: intel: fm10k: Fix parameter idx set but not used Brahmajit Das
2025-09-01 22:13 ` Vadim Fedorenko
2025-09-02 7:24 ` [PATCH v2] " Brahmajit Das
2025-09-02 7:41 ` Vadim Fedorenko
2025-09-02 10:34 ` Vadim Fedorenko [this message]
2025-09-02 10:47 ` Brahmajit Das
2025-09-03 6:08 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-09-03 9:11 ` Brahmajit Das
2025-09-03 9:15 ` Loktionov, Aleksandr
2025-09-03 6:09 ` [Intel-wired-lan] [PATCH] " Loktionov, Aleksandr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7005c02-63dc-4316-905c-e02283e398c5@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=listout@listout.xyz \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).