From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D5EC3A5A2 for ; Fri, 23 Aug 2019 18:07:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BF95206DD for ; Fri, 23 Aug 2019 18:07:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BywAs7hC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405083AbfHWSHf (ORCPT ); Fri, 23 Aug 2019 14:07:35 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:37313 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404508AbfHWSHf (ORCPT ); Fri, 23 Aug 2019 14:07:35 -0400 Received: by mail-wr1-f66.google.com with SMTP id z11so9422935wrt.4 for ; Fri, 23 Aug 2019 11:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=ZaTNXnn5qhb6CIeJzJhltek98I7yqMTH1zqX4NCZwNA=; b=BywAs7hCwaI5dfB85YZrJm4/oaPf+xy3RnbL2OCSpRMwWyQAuaZ7hG8uVx6ryTjImX y2oBsJzgBrFsxYxN980FViMQzAIq9/owJmLh2XJcdf4FfMCzZIrJvgGPJ6DfGC3R+gIB JJSBWG+bsX1GcYwA/6xv+4gLJG9iFozaShMF3+BTHxpFl8T4RkhGG67ELS9TeUwJpgtv A0csDvZ7vLt64tczFtbGUmjJKQtT2FmntNuhpySl3pmrWOWRvi0bYn/p8tx5Ht0P0bR2 wJG2HzLVM6frCHeYirT3VfOe1V9RhUf4c9uZZ2t7FH4g+HrT/tAOUbUjv9k+wIQvu0T3 UJbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=ZaTNXnn5qhb6CIeJzJhltek98I7yqMTH1zqX4NCZwNA=; b=jLVoNuhZZd1AQPh6sQPZFImcfHW8CAVd72HHQB9qdMqZUaCd/mq6Nc8Zztvj5LiShL H1+4bnFJqxnc+4ryc6frc/GOVJquJnDQBp/kDai/IswM4Kbcka2fLNX/ulV4SpAXelGi SdsRaal6zn5rorafOIfLjUw/h3zrx4IsKQtTatwIREwfYP9rVHjZkNtm8p+DTjWHDWbL 8Q3Q/1W5essL9oy8ml9s9hXGwsbgwiVUf7ToxCjj+CTSm1AojhMR9V8m3dNflptrnAPo kdT5l45dqIdVHdzgqCkoO5H4dQhZbMnhqGsByA/5R32BGRaBkyfh4fv3cKv0JNhKnFpS KiQA== X-Gm-Message-State: APjAAAXZDmBZtxLQVC0lHxWG25GzbHHhxKaMm5rnzNICfl0q0xXdNAtC 4uly4Xvo10n6wuuIMuPipckKkiq2 X-Google-Smtp-Source: APXvYqyTHeIUqx/si5SoR8VqaCHTEx6x8vwiHZWr7z2pCwHDbx7gWnSqF/8KkjlTPeZIr1mbasGygQ== X-Received: by 2002:a05:6000:152:: with SMTP id r18mr7086579wrx.41.1566583652767; Fri, 23 Aug 2019 11:07:32 -0700 (PDT) Received: from ?IPv6:2003:ea:8f04:7c00:6c0a:591:b8f7:9101? (p200300EA8F047C006C0A0591B8F79101.dip0.t-ipconnect.de. [2003:ea:8f04:7c00:6c0a:591:b8f7:9101]) by smtp.googlemail.com with ESMTPSA id a141sm18242490wmd.0.2019.08.23.11.07.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Aug 2019 11:07:32 -0700 (PDT) To: Realtek linux nic maintainers , David Miller Cc: Aaro Koskinen , "netdev@vger.kernel.org" From: Heiner Kallweit Subject: [PATCH net-next] r8169: fix DMA issue on MIPS platform Message-ID: Date: Fri, 23 Aug 2019 20:07:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org As reported by Aaro this patch causes network problems on MIPS Loongson platform. Therefore revert it. Fixes: f072218cca5b ("r8169: remove not needed call to dma_sync_single_for_device") Signed-off-by: Heiner Kallweit Reported-by: Aaro Koskinen --- drivers/net/ethernet/realtek/r8169_main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 910944120..6182e7d33 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -5822,6 +5822,10 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget skb->tail += pkt_size; skb->len = pkt_size; + dma_sync_single_for_device(tp_to_dev(tp), + le64_to_cpu(desc->addr), + pkt_size, DMA_FROM_DEVICE); + rtl8169_rx_csum(skb, status); skb->protocol = eth_type_trans(skb, dev); -- 2.23.0