From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Nelson Subject: Re: [PATCH] ixgbevf: off by one in ixgbevf_ipsec_tx() Date: Wed, 19 Sep 2018 08:28:08 -0700 Message-ID: References: <20180919103529.GC9238@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter , Jeff Kirsher Return-path: Received: from aserp2120.oracle.com ([141.146.126.78]:60832 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731661AbeISVGq (ORCPT ); Wed, 19 Sep 2018 17:06:46 -0400 In-Reply-To: <20180919103529.GC9238@mwanda> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 9/19/2018 3:35 AM, Dan Carpenter wrote: > The ipsec->tx_tbl[] array has IXGBE_IPSEC_MAX_SA_COUNT elements so the > > should be a >=. > > Fixes: 0062e7cc955e ("ixgbevf: add VF IPsec offload code") > Signed-off-by: Dan Carpenter Signed-off-by: Shannon Nelson > > diff --git a/drivers/net/ethernet/intel/ixgbevf/ipsec.c b/drivers/net/ethernet/intel/ixgbevf/ipsec.c > index 997cea675a37..4fcbeffce52b 100644 > --- a/drivers/net/ethernet/intel/ixgbevf/ipsec.c > +++ b/drivers/net/ethernet/intel/ixgbevf/ipsec.c > @@ -470,7 +470,7 @@ int ixgbevf_ipsec_tx(struct ixgbevf_ring *tx_ring, > } > > sa_idx = xs->xso.offload_handle - IXGBE_IPSEC_BASE_TX_INDEX; > - if (unlikely(sa_idx > IXGBE_IPSEC_MAX_SA_COUNT)) { > + if (unlikely(sa_idx >= IXGBE_IPSEC_MAX_SA_COUNT)) { > netdev_err(tx_ring->netdev, "%s: bad sa_idx=%d handle=%lu\n", > __func__, sa_idx, xs->xso.offload_handle); > return 0; >