From: Jonathan Toppins <jtoppins@redhat.com>
To: Hangbin Liu <liuhangbin@gmail.com>, netdev@vger.kernel.org
Cc: Jay Vosburgh <j.vosburgh@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net] bonding: get correct NA dest address
Date: Tue, 6 Dec 2022 10:42:35 -0500 [thread overview]
Message-ID: <c7be4ae2-f55e-0277-3c1c-cecad5cc9262@redhat.com> (raw)
In-Reply-To: <20221206032055.7517-1-liuhangbin@gmail.com>
On 12/5/22 22:20, Hangbin Liu wrote:
> In commit 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving
> IPv6 messages"), there is a copy/paste issue for NA daddr. I found that
> in my testing and fixed it in my local branch. But I forgot to re-format
> the patch and sent the wrong mail.
>
> Fix it by reading the correct dest address.
>
> Fixes: 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving IPv6 messages")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Jonathan Toppins <jtoppins@redhat.com>
> ---
> drivers/net/bonding/bond_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index f298b9b3eb77..b9a882f182d2 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -3247,7 +3247,7 @@ static int bond_na_rcv(const struct sk_buff *skb, struct bonding *bond,
> goto out;
>
> saddr = &combined->ip6.saddr;
> - daddr = &combined->ip6.saddr;
> + daddr = &combined->ip6.daddr;
>
> slave_dbg(bond->dev, slave->dev, "%s: %s/%d av %d sv %d sip %pI6c tip %pI6c\n",
> __func__, slave->dev->name, bond_slave_state(slave),
next prev parent reply other threads:[~2022-12-06 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 3:20 [PATCH net] bonding: get correct NA dest address Hangbin Liu
2022-12-06 3:25 ` Eric Dumazet
2022-12-06 9:48 ` Jiri Pirko
2022-12-06 15:42 ` Jonathan Toppins [this message]
2022-12-07 4:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7be4ae2-f55e-0277-3c1c-cecad5cc9262@redhat.com \
--to=jtoppins@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).