[PATCH net] bonding: get correct NA dest address

[PATCH net] bonding: get correct NA dest address

[Hangbin Liu]

In commit 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving
IPv6 messages"), there is a copy/paste issue for NA daddr. I found that
in my testing and fixed it in my local branch. But I forgot to re-format
the patch and sent the wrong mail.

Fix it by reading the correct dest address.

Fixes: 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving IPv6 messages")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 drivers/net/bonding/bond_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index f298b9b3eb77..b9a882f182d2 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -3247,7 +3247,7 @@ static int bond_na_rcv(const struct sk_buff *skb, struct bonding *bond,
 		goto out;
 
 	saddr = &combined->ip6.saddr;
-	daddr = &combined->ip6.saddr;
+	daddr = &combined->ip6.daddr;
 
 	slave_dbg(bond->dev, slave->dev, "%s: %s/%d av %d sv %d sip %pI6c tip %pI6c\n",
 		  __func__, slave->dev->name, bond_slave_state(slave),
-- 
2.38.1

Re: [PATCH net] bonding: get correct NA dest address

[Eric Dumazet]

On Tue, Dec 6, 2022 at 4:21 AM Hangbin Liu <liuhangbin@gmail.com> wrote:
>
> In commit 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving
> IPv6 messages"), there is a copy/paste issue for NA daddr. I found that
> in my testing and fixed it in my local branch. But I forgot to re-format
> the patch and sent the wrong mail.
>
> Fix it by reading the correct dest address.
>
> Fixes: 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving IPv6 messages")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
>  drivers/net/bonding/bond_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index f298b9b3eb77..b9a882f182d2 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -3247,7 +3247,7 @@ static int bond_na_rcv(const struct sk_buff *skb, struct bonding *bond,
>                 goto out;
>
>         saddr = &combined->ip6.saddr;
> -       daddr = &combined->ip6.saddr;
> +       daddr = &combined->ip6.daddr;
>

Indeed, thanks.

Reviewed-by: Eric Dumazet <edumazet@google.com>

Re: [PATCH net] bonding: get correct NA dest address

[Jiri Pirko]

Tue, Dec 06, 2022 at 04:20:55AM CET, liuhangbin@gmail.com wrote:
>In commit 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving
>IPv6 messages"), there is a copy/paste issue for NA daddr. I found that
>in my testing and fixed it in my local branch. But I forgot to re-format
>the patch and sent the wrong mail.
>
>Fix it by reading the correct dest address.
>
>Fixes: 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving IPv6 messages")
>Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

Reviewed-by: Jiri Pirko <jiri@nvidia.com>

Re: [PATCH net] bonding: get correct NA dest address

[Jonathan Toppins]

On 12/5/22 22:20, Hangbin Liu wrote:
> In commit 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving
> IPv6 messages"), there is a copy/paste issue for NA daddr. I found that
> in my testing and fixed it in my local branch. But I forgot to re-format
> the patch and sent the wrong mail.
> 
> Fix it by reading the correct dest address.
> 
> Fixes: 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving IPv6 messages")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

Acked-by: Jonathan Toppins <jtoppins@redhat.com>

> ---
>   drivers/net/bonding/bond_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index f298b9b3eb77..b9a882f182d2 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -3247,7 +3247,7 @@ static int bond_na_rcv(const struct sk_buff *skb, struct bonding *bond,
>   		goto out;
>   
>   	saddr = &combined->ip6.saddr;
> -	daddr = &combined->ip6.saddr;
> +	daddr = &combined->ip6.daddr;
>   
>   	slave_dbg(bond->dev, slave->dev, "%s: %s/%d av %d sv %d sip %pI6c tip %pI6c\n",
>   		  __func__, slave->dev->name, bond_slave_state(slave),

Re: [PATCH net] bonding: get correct NA dest address

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  6 Dec 2022 11:20:55 +0800 you wrote:
> In commit 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving
> IPv6 messages"), there is a copy/paste issue for NA daddr. I found that
> in my testing and fixed it in my local branch. But I forgot to re-format
> the patch and sent the wrong mail.
> 
> Fix it by reading the correct dest address.
> 
> [...]

Here is the summary with links:
  - [net] bonding: get correct NA dest address
    https://git.kernel.org/netdev/net/c/1f154f3b56a1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html