From: Chris Mason <clm@meta.com>
To: Jakub Kicinski <kuba@kernel.org>, Eric Dumazet <edumazet@google.com>
Cc: netdev@vger.kernel.org, syzkaller@googlegroups.com,
andy@greyhouse.net, eric.dumazet@gmail.com, pabeni@redhat.com,
j.vosburgh@gmail.com, davem@davemloft.net
Subject: Re: [net] bonding: annotate data-races around slave->last_rx
Date: Thu, 22 Jan 2026 12:42:35 -0500 [thread overview]
Message-ID: <c7e1b0e6-c405-4dde-aeec-c1e4a95532be@meta.com> (raw)
In-Reply-To: <20260122085813.47f7c195@kernel.org>
On 1/22/26 11:58 AM, Jakub Kicinski wrote:
> On Thu, 22 Jan 2026 16:56:33 +0100 Eric Dumazet wrote:
>> On Thu, Jan 22, 2026 at 4:50 PM Eric Dumazet <edumazet@google.com> wrote:
>>> On Thu, Jan 22, 2026 at 4:29 PM Jakub Kicinski <kuba@kernel.org> wrote:
>>>> I guess if nothing else we should do it for consistency?
>>>
>>> To be clear, I will cook a V2 with this part.
>>>
>>
>> _bond_options_ns_ip6_target_set() probably needs a fix as well.
>>
>> Is AI review stopping at the first error ?
>
> I don't think it explicitly stops after the first occurrence but it
> seems to have limited ability to dig around. Simplifying, it only digs
> around for 5-10min, and it spends a lot of time proving that the
> issue is real. So once it's spend time proving one issue it's often out
> of time, and may not search for another one :(
>
> Ccing Chris, hopefully he'll chime in later if I'm wrong.
It's supposed to keep hunting for bugs until it has reviewed the entire
thing, and then run all the bugs it found through the false positive pass.
But, sometimes it gets really excited and jumps out early, or as Jakub
mentions sometimes the context window fills and it starts skipping
steps. I've tried different ways to force things, but unfortunately
none of them have worked 100% of the time.
-chris
prev parent reply other threads:[~2026-01-22 17:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 15:28 [PATCH net] bonding: annotate data-races around slave->last_rx Eric Dumazet
2026-01-22 2:22 ` [net] " Jakub Kicinski
2026-01-22 4:42 ` Eric Dumazet
2026-01-22 15:28 ` Jakub Kicinski
2026-01-22 15:50 ` Eric Dumazet
2026-01-22 15:56 ` Eric Dumazet
2026-01-22 15:57 ` Eric Dumazet
2026-01-22 16:58 ` Jakub Kicinski
2026-01-22 17:42 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7e1b0e6-c405-4dde-aeec-c1e4a95532be@meta.com \
--to=clm@meta.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox