From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Haiyang Zhang <haiyangz@microsoft.com>,
devel@linuxdriverproject.org, netdev@vger.kernel.org
Cc: KY Srinivasan <kys@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: hyperv/netvsc: Delete two error messages for a failed memory allocation in netvsc_init_buf()
Date: Mon, 15 Jan 2018 10:00:11 +0100 [thread overview]
Message-ID: <c7ffcb1d-107c-c49b-b3bf-9b0f260e7214@users.sourceforge.net> (raw)
In-Reply-To: <CY4PR2101MB0867CEFAF4FB72AF47FA3AA7CA130@CY4PR2101MB0867.namprd21.prod.outlook.com>
> These messages are not displayed anywhere else:
> "unable to allocate receive buffer of size %u\n"
> "unable to allocate send buffer of size %u\n",
>
> After set ret = -ENOMEM; and cleanup, we won't know which buffer allocation failed without the error message.
How do you think about to achieve the distinction for these buffers by any other means?
Can a detailed function call stack dump be appropriate?
> So please do not remove these messages.
Would you dare to adjust this function implementation in any other ways?
Regards,
Markus
prev parent reply other threads:[~2018-01-15 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-07 20:10 [PATCH] hyperv/netvsc: Delete two error messages for a failed memory allocation in netvsc_init_buf() SF Markus Elfring
2018-01-08 15:37 ` Haiyang Zhang
2018-01-08 18:19 ` SF Markus Elfring
2018-01-15 9:00 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7ffcb1d-107c-c49b-b3bf-9b0f260e7214@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).